After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322834 - Wrong value for needed space, when writing an ISO image
Wrong value for needed space, when writing an ISO image
Status: RESOLVED FIXED
Product: nautilus-cd-burner
Classification: Deprecated
Component: cd-burner
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus CD Burner Maintainers
Nautilus CD Burner Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-30 13:16 UTC by Fabio Bonelli
Modified: 2005-11-30 17:08 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Fix for this bug (1.40 KB, patch)
2005-11-30 13:19 UTC, Fabio Bonelli 		none Details | Review

Description Fabio Bonelli 2005-11-30 13:16:15 UTC 
n-c-b miscalculates xx in the dialog that says "The selected location does not
have enough space to store the disc image (xx needed)".
Comment 1 Fabio Bonelli 2005-11-30 13:19:41 UTC 
Created attachment 55420 [details] [review]
Fix for this bug

Fixes the bug.
Question: Should it be preferable to report the needed space, instead of the
whole ISO size? (iso size - free_space_on_disk) instead of (iso_size)
Comment 2 William Jon McCann 2005-11-30 17:08:07 UTC 
Looks good.  Only problem is that for translation it is better for the format to
be in a separate string.  I also moved this code into a separate function.  And
your idea to report needed space is a good one.  I've committed this all to
HEAD.  Thanks!

2005-11-30  William Jon McCann  <mccann@jhu.edu>

	* make-iso.c (get_image_space_error_message): 
	(nautilus_burn_make_iso, nautilus_burn_make_iso_from_drive):
	Report space needed instead of image size.

2005-11-30  William Jon McCann  <mccann@jhu.edu>

	* make-iso.c (get_image_space_error_message) 
	(nautilus_burn_make_iso, nautilus_burn_make_iso_from_drive):
	Use proper format for number in message.

	Based on patch from Fabio Bonelli <fabiobonelli@libero.it>
	Fixes #322834.