After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322487 - Preferences use deprecated GtkOptionMenu
Preferences use deprecated GtkOptionMenu
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Preferences
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-26 11:51 UTC by Jaap A. Haitsma
Modified: 2005-12-08 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to change GtkOptionMenu to GtkComboBox in libeel (15.26 KB, patch)
2005-11-26 12:02 UTC, Jaap A. Haitsma 		none Details | Review
The patch to nautilus-nautilus-file-management-properties.c|glade (51.67 KB, patch)
2005-11-26 12:08 UTC, Jaap A. Haitsma 		none Details | Review

Description Jaap A. Haitsma 2005-11-26 11:51:30 UTC 
It should use GtkCombobox
Patch coming up
Comment 1 Jaap A. Haitsma 2005-11-26 12:02:29 UTC 
Created attachment 55245 [details] [review]
Patch to change GtkOptionMenu to GtkComboBox in libeel

It's necessary to make a change first in libeel to remove gtkoptionmenu from
the preferences dialog
Comment 2 Jaap A. Haitsma 2005-11-26 12:08:43 UTC 
Created attachment 55246 [details] [review]
The patch to nautilus-nautilus-file-management-properties.c|glade

Besides changing GtkOptionMenu to GtkComboBox. The patch does two extra small
thingies:
1. It's sets the window icon in a much simpler fashion
(gtk_window_set_icon_name)
2. The hint of the dialog is set to dialog. This way the dialog won't have a
maximize and minimize button anymore, which is standard practice for capplets
and dialogs
Comment 3 Sebastien Bacher 2005-11-27 11:26:55 UTC 
Thanks for your patch. Could you send it on the nautilus list, maintainers use
the list for this
Comment 4 Alexander Larsson 2005-12-08 16:27:42 UTC 
I commited this. Thanks.