After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322435 - Build failure against DBUS HEAD
Build failure against DBUS HEAD
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: general
SVN TRUNK
Other Linux
: Normal blocker
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
: 323758 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-11-25 14:51 UTC by Luca Ferretti
Modified: 2005-12-11 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to remove DBUS define usage (1.22 KB, patch)
2005-11-26 12:11 UTC, Richard Hughes 		none Details | Review

Description Luca Ferretti 2005-11-25 14:51:31 UTC 
It seems related to a change in DBUS:

2005-11-22  John (J5) Palmieri  <johnp@redhat.com>

        * configure.in: Add test/name-test/Makefile to the generated
        Makefile list

        * dbus/dbus-shared.h (#define DBUS_NAME_FLAG_ALLOW_REPLACEMENT):
        New flag which replaces DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT
        (#define DBUS_NAME_FLAG_DO_NOT_QUEUE): New flag for specifying
        not to queue an ower if it can't be the primary owne

File to change is /src/gpm-dbus-common.c line 88
Comment 1 Richard Hughes 2005-11-25 17:26:35 UTC 
Has this been released in an official dbus version? If not so, I can't depend on
DBUS HEAD now, but I can quite easily add a compatability #define or #ifdef.
Could you do a simple patch that had #ifdef DBUS_NAME_FLAG_DO_NOT_QUEUE and then
enabled/disabled different calls in gpm-dbus-common.c? Thanks. Richard.
Comment 2 Luca Ferretti 2005-11-25 20:11:52 UTC 
Yes

2005-11-22  John (J5) Palmieri  <johnp@redhat.com>

        * configure.in:
        - Change version to 0.60 for impending release
        - upped the sonames because of ABI and API breakage
Comment 3 Richard Hughes 2005-11-26 12:11:13 UTC 
Created attachment 55247 [details] [review]
Patch to remove DBUS define usage

Okay, until we depend on DBUS 0.60, does the attached patch make g-p-m build?
Comment 4 Luca Ferretti 2005-11-26 13:58:02 UTC 
BTW same issue on totem. See bug #322436
Comment 5 Richard Hughes 2005-11-27 18:22:08 UTC 
Does CVS now build against DBUS HEAD?
Comment 6 Luca Ferretti 2005-11-27 19:24:57 UTC 
Yes. it build.
Comment 7 Richard Hughes 2005-12-11 17:58:53 UTC 
*** Bug 323758 has been marked as a duplicate of this bug. ***