After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322077 - [podcast] rb doesn't play undownloaded podcast sorted after downloaded
[podcast] rb doesn't play undownloaded podcast sorted after downloaded
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
0.9.x
Other Linux
: High major
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 325754 326176 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-11-21 21:35 UTC by Baptiste Mille-Mathias
Modified: 2006-02-05 11:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to stop after podcasts (1.65 KB, patch)
2006-01-06 04:38 UTC, James "Doc" Livingston
none Details | Review
updated patch (1.72 KB, patch)
2006-01-08 06:36 UTC, William Jon McCann
committed Details | Review

Description Baptiste Mille-Mathias 2005-11-21 21:35:27 UTC
Play a downloaded podcast entirely placed before a not downloaded episode

Result:
At the end of the episode, RB will change of track in the UI, but will continue
to play the same track
Comment 1 Baptiste Mille-Mathias 2005-11-21 21:45:48 UTC
sorry I forgot the summary...
Comment 2 James "Doc" Livingston 2005-11-22 06:19:26 UTC
I've seen something similar with iradio, but I can't remember if I filed it.

What is happening is that when attempting to play an entry (the next episode,
the station you clicked on) fails, Rhythmbox reverts to playing what was playing
before. This happens even if the last playing thing was a song and you doubled
clicked on a radio station (which fails).
Comment 3 James "Doc" Livingston 2006-01-06 04:38:36 UTC
Created attachment 56838 [details] [review]
patch to stop after podcasts

I think that a better behaviour is simply to stop when an episode finishes playing. Problems occur (like the above) if the episode isn't downloaded or is currently being downloaded, and in many cases hearing the next one down the list isn't what the user want to do anyway.

The patch adds support for sources to stop when playback finishes, and makes the podcast source do that.
Comment 4 James "Doc" Livingston 2006-01-08 06:13:36 UTC
*** Bug 326176 has been marked as a duplicate of this bug. ***
Comment 5 Jonathan Matthew 2006-01-08 06:17:43 UTC
What does this do if you're playing a podcast episode from the play queue?  I'd like it to go to the next song in that case.
Comment 6 James "Doc" Livingston 2006-01-08 06:24:42 UTC
You can't put podcasts in the queue right now, but it should go to the next thing because the queue source uses the default of RB_SOURCE_EOF_NEXT.

It seems to work fine if you playing a podcast and have a normal song in the queue (it plays the queue until empty and then stops).
Comment 7 William Jon McCann 2006-01-08 06:36:08 UTC
Created attachment 56955 [details] [review]
updated patch

Without pausing first the play button/state seems to get confused.  Works for me.
Comment 8 James "Doc" Livingston 2006-01-11 11:08:34 UTC
I've committed the patch to cvs, with the issue mentioned in comment #7 fixed properly - _set_playing_source and _set_playing_entry now emit notification on the "playing" property.
Comment 9 James "Doc" Livingston 2006-02-05 11:56:31 UTC
*** Bug 325754 has been marked as a duplicate of this bug. ***