After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322075 - Unmaximizing a window can cause the titlebar to be placed under the top panel
Unmaximizing a window can cause the titlebar to be placed under the top panel
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: High normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks: 155458
 
 
Reported: 2005-11-21 21:23 UTC by Elijah Newren
Modified: 2005-11-22 15:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unmaximizing and unfullscreening shouldn't count as manual user movement/resizing (3.40 KB, patch)
2005-11-21 21:24 UTC, Elijah Newren 		none Details | Review

Description Elijah Newren 2005-11-21 21:23:10 UTC 
Sebastien reported this one in irc and gave me a verbose debugging log.  Really
simple cause, and it also turn out to effect unfullscreening a window as well
(basically, I treated both as the user was manually moving/resizing a window so
naturally the keep-fully-onscreen constraints stupidly didn't apply...)

Patch will be attached in a minute...
Comment 1 Elijah Newren 2005-11-21 21:24:34 UTC 
Created attachment 55054 [details] [review]
unmaximizing and unfullscreening shouldn't count as manual user movement/resizing

Sebastien: could you try out this patch?  Thanks.
Comment 2 Sebastien Bacher 2005-11-22 15:42:17 UTC 
works fine for me, thanks
Comment 3 Elijah Newren 2005-11-22 15:49:46 UTC 
2005-11-22  Elijah Newren  <newren@gmail.com>

	Don't allow removing a window from maximized or fullscreened state
	to place the titlebar under the top panel.  Fixes #322075.

	* src/display.c (handle_net_moveresize_window): fix up previous
	comments now that I know a little more, modify the code just
	slightly to clarify that this is NOT a manual user move/resize
	operation

	* src/window.c (meta_window_unmaximize,
	  meta_window_unmake_fullscreen,
	  meta_window_shove_titlebar_onscreen):
	don't claim that these are manual user move/resize operations