After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322071 - Bottom constraint overly restrictive
Bottom constraint overly restrictive
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks: 155458
 
 
Reported: 2005-11-21 20:28 UTC by Rob Adams
Modified: 2005-11-22 00:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow users to move windows off the bottom of the screen except for the titlebar. (1.98 KB, patch)
2005-11-21 20:49 UTC, Elijah Newren
needs-work Details | Review
Handle decorationless windows (2.17 KB, patch)
2005-11-22 00:18 UTC, Elijah Newren
committed Details | Review

Description Rob Adams 2005-11-21 20:28:09 UTC
I don't really see a lot of reason to ensure that so much of the window be
visible on the bottom -- really as long as the titlebar is kept onscreen it
should be enough.  So maybe modify the bottom constraint to the height of the
titlebar for decorated windows?  This is closer to the way the old metacity worked.

Not sure if there's a technical or usability reason for the change though.
Comment 1 Elijah Newren 2005-11-21 20:48:14 UTC
Well, the technical reason was I didn't look that closely at the old code in
this particular case and didn't think about the differences that much.  Easy
enough to change if we want to.
Comment 2 Elijah Newren 2005-11-21 20:49:49 UTC
Created attachment 55053 [details] [review]
Allow users to move windows off the bottom of the screen except for the titlebar.

This is just quick 'n dirty to show that it's easy.  We'd have to modify it for
frameless windows as this patch would allow it entirely offscreen.  If we want
the change I can go ahead and fix it up.
Comment 3 Elijah Newren 2005-11-22 00:18:02 UTC
Created attachment 55057 [details] [review]
Handle decorationless windows

Actually, since this is basically just what the old code does and it wasn't
considered a bug, let's just make it do the same thing; here's the patch that
fixes up the frameless case as well.
Comment 4 Elijah Newren 2005-11-22 00:20:12 UTC
2005-11-21  Elijah Newren  <newren@gmail.com>

	* src/constraints.c (constrain_partially_onscreen): Relax the
	partially onscreen constraint to allow the titlebar to touch the
	bottom panel in order to make the new constraints code function
	the same as the old version.  Fixes #322071.