After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321826 - Always include <config.h> first
Always include <config.h> first
Status: RESOLVED DUPLICATE of bug 340016
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.0
Other AIX
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-18 19:52 UTC by The Written Word
Modified: 2006-04-30 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Include <config.h> first in some .c files. (5.84 KB, patch)
2005-11-18 19:52 UTC, The Written Word 		needs-work Details | Review

Description The Written Word 2005-11-18 19:52:01 UTC 
Distribution/Version: 5.3

<config.h> should always be included first in the event one of the #define's
alters something in a standard header file.
Comment 1 The Written Word 2005-11-18 19:52:43 UTC 
Created attachment 54924 [details] [review]
Include <config.h> first in some .c files.
Comment 2 Andy Wingo 2005-11-30 11:36:56 UTC 
This looks OK to be applied to 0.8. Can you try building against version 0.9.6
or 0.9.7 (to be released later today)?
Comment 3 Andy Wingo 2006-01-13 12:55:48 UTC 
Actually on second thought it would be better to explicitly include config.h instead of relying on gst_private to include it, so that system headers are pulled in before GLib. Can you build 0.10 (the current stable series) and come up with a new patch please? Thanks.
Comment 4 Tim-Philipp Müller 2006-04-30 11:46:32 UTC 
Marking as duplicate of bug #340016, because #340016 has patches relevant to 0.10/HEAD and this one doesn't.


*** This bug has been marked as a duplicate of 340016 ***