After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321325 - Plugin-specific preferences
Plugin-specific preferences
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks: 342183
 
 
Reported: 2005-11-12 23:00 UTC by David Trowbridge
Modified: 2006-11-02 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David Trowbridge 2005-11-12 23:00:28 UTC 
It would be great to allow plugins to provide their own preferences page.
Comment 1 Guillaume Desmottes 2006-07-27 17:51:17 UTC 
How do you see that in the UI?

When a plugin is activated he adds a new entry in the preference menu on the left?
Or we add a button "Properties" (under "Open" and "Remove") that opens a dialog with plugin's properties?

I think that i prefer the first solution.
Comment 2 David Trowbridge 2006-07-27 21:09:31 UTC 
I was thinking the first one
Comment 3 Guillaume Desmottes 2006-08-20 21:41:35 UTC 
I'm working on this.

In my current design, i have to "gobjectize" the PreferencePluginsPage (to be able to emmit a signal when a new plugin is loaded).
Any objection with that?
Comment 4 David Trowbridge 2006-08-20 23:14:11 UTC 
sounds fine to me.
Comment 5 Guillaume Desmottes 2006-08-21 14:03:38 UTC 
done.
I'm not a GObject specialist so review and feedback would be welcome.

I continue my work on this bug.
Comment 6 Guillaume Desmottes 2006-11-02 18:02:18 UTC 
OK, i just commited my patch to implement this feature.
I also add a preferences page for the notification plugin.

Testing and feedback are most than welcome.

2006-11-02  Guillaume Desmottes <cass@skynet.be>

	A src/fe-gnome/preferences-page.c:
	A src/fe-gnome/preferences-page.h:
	* src/fe-gnome/preferences-page-dcc.c:
	* src/fe-gnome/preferences-page-dcc.h:
	* src/fe-gnome/preferences-page-irc.c:
	* src/fe-gnome/preferences-page-irc.h:
	* src/fe-gnome/preferences-page-colors.c:
	* src/fe-gnome/preferences-page-colors.h:
	* src/fe-gnome/preferences-page-networks.c:
	* src/fe-gnome/preferences-page-spellcheck.c:
	* src/fe-gnome/preferences-page-networks.h:
	* src/fe-gnome/preferences-page-spellcheck.h:
	* src/fe-gnome/preferences-page-effects.c:
	* src/fe-gnome/preferences-page-effects.h
	* src/fe-gnome/Makefile.am:
	  - GObjectize preferences pages.
	  - Make them inherit from PreferencesPage.

	* src/fe-gnome/preferences-page-plugins.c:
	* src/fe-gnome/preferences-page-plugins.h:
	* src/fe-gnome/preferences-dialog.c:
	* src/fe-gnome/preferences-dialog.h:
	  - Add the ability to plugins to have their own
	    preferences page. (#321325)

	A plugins/notification/preferences-notification.glade:
	A plugins/notification/preferences-page-plugin-notification.h:
	A plugins/notification/preferences-page-plugin-notification.c:
	* plugins/notification/TODO:
	* plugins/notification/notification.c:
	* plugins/notification/Makefile.am:
	* NEWS:
	* po/POTFILES.in:
	  - Add a preference page to configure the level of notification.


Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.