GNOME Bugzilla – Bug 321140
Lots of cleanups for compiler warnings and removal of unneeded code
Last modified: 2006-01-04 23:42:05 UTC
Patch attached. - mark functions static - declare functions in headers when used in more than one file - remove useless code - fix #if vs. #ifdef in many cases - other cleanups
Created attachment 54573 [details] [review] patch as described
clearlooks/src/clearlooks_draw.c | 20 -- clearlooks/src/clearlooks_draw.h | 18 + clearlooks/src/clearlooks_style.c | 49 +---- clearlooks/src/clearlooks_style.h | 2 clearlooks/src/support.c | 4 clearlooks/src/support.h | 9 crux/src/crux-draw.c | 113 +----------- crux/src/crux-main.c | 6 crux/src/crux-rc-parser.c | 16 - crux/src/crux-rc-style.c | 3 hc/src/hc-main.c | 2 hc/src/hc-style.c | 6 industrial/src/industrial_style.c | 62 +----- lighthouseblue/src/lighthouseblue_style.c | 13 - metal/src/metal_gtk2_drawing.c | 34 +-- metal/src/metal_gtk2_engine.c | 4 metal/src/metal_gtk2_misc.h | 14 + mist/src/mist-rc-style.c | 1 mist/src/mist-style.c | 15 - redmond/src/redmond_gtk2_drawing.c | 1 redmond/src/redmond_gtk2_engine.c | 2 redmond/src/redmond_gtk2_misc.c | 3 smooth/src/engine/shared/gtk/smooth_gtk_drawing.c | 12 - smooth/src/engine/shared/gtk/smooth_gtk_misc.c | 8 smooth/src/engine/smooth_gtk2_drawing.c | 42 ---- smooth/src/engine/smooth_gtk2_misc.c | 8 smooth/src/engine/smooth_gtk2_rc.c | 2 smooth/src/interfaces/abstract/abstract_drawing_interface.c | 4 smooth/src/interfaces/drawing_interface.c | 6 smooth/src/interfaces/gdk2/gdk2_drawing_interface.c | 8 smooth/src/interfaces/gdk2/src/gdk2_gradient_routines.c | 14 - smooth/src/interfaces/shared/gdk/gdk_drawing_interface.c | 9 smooth/src/utils/draw_arrows.c | 26 -- smooth/src/utils/draw_arrows.h | 4 smooth/src/utils/draw_border.c | 15 - smooth/src/utils/draw_checkmark.c | 3 smooth/src/utils/draw_grips.c | 2 thinice/src/thinice_rc_style.c | 2 thinice/src/thinice_theme_draw.c | 11 - 39 files changed, 165 insertions(+), 408 deletions(-)
It would be useful to have per-engine patches, since each engine is usually maintained by a different person.
Created attachment 54582 [details] [review] patch for clearlooks
Created attachment 54583 [details] [review] patch for crux
Created attachment 54584 [details] [review] patch for hc
Created attachment 54585 [details] [review] patch for industrial
Created attachment 54586 [details] [review] patch for lighthouseblue
Created attachment 54587 [details] [review] patch for metal
Created attachment 54588 [details] [review] patch for mist
Created attachment 54589 [details] [review] patch for redmond
Created attachment 54590 [details] [review] patch for smooth
Created attachment 54591 [details] [review] patch for thinice
I applied the Clearlooks patch. Thank you Kjartan!
Created attachment 54652 [details] [review] updated patch Forgot to get removed files into the patch.
Committed Crux and HC patches to gtk-engines-2-6 branch. Some of the work in the Crux patch has already happened in HEAD, but we will need to make sure any relevent parts of these patches get applied to HEAD aswell.
I've committed most of the patches now. The individual patch for lighthouseblue appears to be the patch for industrial.
Will attach a new lighthouse_blue patch when I have access to CVS again.
Created attachment 56008 [details] [review] correct patch for lighthouse blue
Created attachment 56273 [details] [review] fix too agressive removal of functions This fixes the problems with undefined symbols after too agressive removal of functions in previous patches for the smooth engine.
hc, industrial, mist, redmond and thinice have been committed to HEAD Crux is obsolete/committed in HEAD Clearlooks is possibly obsolete (Richard - can you check this please) Smooth patch is committed to HEAD, but now needs the second Smooth patch applied (patch 56373) Everything except the lighthouseblue patch has been comitted to the gtk-engines-2-6 branch. This includes the Smooth patch, but now needs the second Smooth patch applied (patch 56373)
Comment on attachment 56273 [details] [review] fix too agressive removal of functions I commited this to both branches now.
I've committed the Lighthouseblue patch to both the gtk-engines-2-6 branch, and to head. Closing the bug as all patches have now been comitted.