After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321087 - GaimLog backend indexes arbitrary files
GaimLog backend indexes arbitrary files
Status: RESOLVED FIXED
Product: beagle
Classification: Other
Component: General
0.1.x
Other Linux
: Normal normal
: ---
Assigned To: Daniel Drake
Daniel Drake
Depends on:
Blocks:
 
 
Reported: 2005-11-09 20:01 UTC by Cameron Meadors
Modified: 2005-11-27 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GaimLogQueryable cleanups (7.27 KB, patch)
2005-11-13 23:30 UTC, Daniel Drake 		committed Details | Review

Description Cameron Meadors 2005-11-09 20:01:56 UTC 
The GaimLog backend recursively indexes all files/directories in the log
directory.  It should only index known files.

Specific issues with .svn files.
Comment 1 Daniel Drake 2005-11-13 23:30:14 UTC 
Created attachment 54718 [details] [review]
GaimLogQueryable cleanups

The gaim backend was slightly untidy:

We were crawling all directories in GaimLogCrawler to find log files, and also
in GaimLogQueryable to create inotify watches.
We were indexing all levels of subdir nesting and any file within.
GaimLogCrawler was caching write times where LuceneQueryable does that for us
(and it was also doing unneccessary DateTime allocations in FileIsInteresting)

This patch solves all that and eliminates GaimLogCrawler. I may have gone a
little over the top on the filename checking, but using something like regular
expressions every time someone says something is too expensive...

Cameron, could you please try this against your test data?