After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320766 - [API] collect pads API changes
[API] collect pads API changes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.9.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 319388
 
 
Reported: 2005-11-05 16:01 UTC by Tim-Philipp Müller
Modified: 2005-11-21 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2005-11-05 16:01:56 UTC 
We might want to add a  GstCollectFlags flags  parameter to
gst_collect_pads_add_pad() to make it more future proof.

Cheers
 -Tim
Comment 1 Tim-Philipp Müller 2005-11-06 10:34:40 UTC 
Proposed changes to the collect pads API:

 * add a flags argument to gst_collect_pads_add_pad()

 * rename all gst_collectpads_foo() to gst_collect_pads_foo(),
   after all it's GstCollectPads and not GstCollectpads.

Cheers
 -Tim
Comment 2 Tim-Philipp Müller 2005-11-06 11:41:09 UTC 
Also check these function, that currently do nothing at all:

gboolean
gst_collectpads_is_active (GstCollectPads * pads, GstPad * pad)
{
  return FALSE;
}


GstFlowReturn
gst_collectpads_collect (GstCollectPads * pads)
{
  return GST_FLOW_ERROR;
}


GstFlowReturn
gst_collectpads_collect_range (GstCollectPads * pads, guint64 offset,
    guint length)
{
  return GST_FLOW_ERROR;
}
Comment 3 Andy Wingo 2005-11-10 14:54:54 UTC 
Collect range is good to have in the api; i´d like to implement it at some point.
Comment 4 Andy Wingo 2005-11-11 16:24:27 UTC 
why flags?
Comment 5 Andy Wingo 2005-11-19 18:40:07 UTC 
ping? you want to go ahead and do this, tim?
Comment 6 Tim-Philipp Müller 2005-11-20 22:35:21 UTC 
I'll do the collectpads to collect_pads renaming on Monday if there's no
objections and leave everything else as is.

I don't have a specific reason for the flags, I just thought it might be useful
in future. Will not add them for now.
Comment 7 Tim-Philipp Müller 2005-11-21 11:31:56 UTC 
API rename fixed in CVS. No flags added to _add_pad(). Documented unimplemented
functions as unimplemented.