Bug 320329 - Add Bookmark dialog OK button
Add Bookmark dialog OK button
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
1.9.x
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2005-10-31 17:05 UTC by spark
Modified: 2006-02-14 11:48 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spark 2005-10-31 17:05:35 UTC 
Version details: 1.8.2

To repro:

1). Open the History window
2). Select a history entry
3). Click File -> Add Bookmark
4). Click either Cancel or OK

Results: Main Epiphany window is focused
Expected: History window is focused

Aside: the "OK" button in this dialog should probably say "Add" (and have the
appropriate icon)
Comment 1 spark 2005-10-31 17:09:17 UTC 
Strangely if the click anywhere on on the Add Bookmark dialog (not on a widget)
when launched from history, the main ephy window comes forward so it's behind
the Add Bookmark dialog.
Comment 2 Christian Persch 2005-10-31 18:53:22 UTC 
Thanks for the bug report!

I fixed the parent window problem on HEAD and gnome-2-12. That only leaves the
button issue to be fixed.
Comment 3 Reinout van Schouwen 2006-01-11 13:33:36 UTC 
cc'ing harves...
Comment 4 Peter Harvey 2006-01-13 20:30:34 UTC 
Before I change the button text, I want to briefly explain.

The bookmark is created the instant you select "Add Bookmark". The window that is shown is the bookmark properties window, except that the buttons have slightly semantics to the usual properties window. "OK" closes the window. "Cancel" deletes the bookmark and closes the window. In the usual bookmark properties window we just have a "Close" button.

Do we still want to change the text to "Add" seeing as the bookmark is technically already created? Just want to check.
Comment 5 Reinout van Schouwen 2006-01-13 21:44:34 UTC 
It doesn't really matter whether the bookmark is technically already created or not. Browsing through http://developer.gnome.org/projects/gup/hig/2.0/windows-alert.html#alerts-confirmation, I get the impression that, while OK is not necessarily wrong, an Add button would be preferable here.
Comment 6 Peter Harvey 2006-02-14 11:48:39 UTC 
Fixed in CVS.
Note You need to log in before you can comment on or make changes to this bug.