After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320087 - Cache freqently-called slow templates with an XSLT extension
Cache freqently-called slow templates with an XSLT extension
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: DocBook
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Brent Smith (smitten)
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-28 15:10 UTC by Shaun McCance
Modified: 2006-07-01 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch that implements this (5.59 KB, patch)
2006-07-01 17:17 UTC, Brent Smith (smitten)
committed Details | Review

Description Shaun McCance 2005-10-28 15:10:58 UTC
In particular, the XSLT templates that create numbers for sections and formal
block objects could be called dozens of times on each element.  There's only so
much that can be done to speed those templates up, so we should see what we can
do inside of Yelp.

It should be possible to register a yelp:cache extension element, and wrap the
contents of those templates with it.  This would call back to a function in Yelp
which checks to see if that template has already been called on that element. 
If so, it returns a cached value.  Otherwise, it runs the XSLT and stores the
value for later calls.
Comment 1 Don Scorgie 2006-01-06 16:02:03 UTC
Is this still worth doing now that Yelp is quick again, or can this bug be closed?
Comment 2 Shaun McCance 2006-01-06 18:41:07 UTC
Yup.  My timings still indicate that we can get a noticeable speed improvement on large documents by doing this.  Anybody who's interested should ping me.  It's pretty straight-forward.
Comment 3 Brent Smith (smitten) 2006-07-01 17:17:59 UTC
Created attachment 68250 [details] [review]
patch that implements this

already committed to HEAD.  see my post on gnome-doc-devel-list on June 29th, 2006 for more information.  Speeds up Gnumeric manual from 55secs to 25seconds.