After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319666 - Empty tree tables should announce themselves as empty.
Empty tree tables should announce themselves as empty.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 2.18.0
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-24 21:13 UTC by Rich Burridge
Modified: 2008-07-22 19:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to hopefully fix the problem. (757 bytes, patch)
2006-11-16 19:06 UTC, Rich Burridge 		none Details | Review
Patch to also speak empty tables (757 bytes, patch)
2006-11-30 23:36 UTC, Willie Walker 		none Details | Review
Patch to also speak empty tables (1.41 KB, patch)
2006-12-01 13:54 UTC, Willie Walker 		none Details | Review
Patch to also speak empty layered panes (which I think was the original problem) (3.61 KB, patch)
2006-12-03 11:02 UTC, Willie Walker 		committed Details | Review

Description Rich Burridge 2005-10-24 21:13:31 UTC 
Empty tree tables should announce themselves as empty.
Comment 1 Willie Walker 2006-07-25 23:30:59 UTC 
Thank you!  Looks like a bug.
Comment 2 Cody 2006-08-10 23:23:52 UTC 
(In reply to comment #0)
> Empty tree tables should announce themselves as empty.
> 
this bug is very vague and does not contain enough details. Most tree tables speak but as for bug 350674, is specifically aimed towards the add to panel tree table of available items. The issue here is that orca says "layered pane. panel greyed'. this does not make sense to me and orca should be able to speak the items. Doing a flat review doesn't reveal much.

Cody
Comment 3 Willie Walker 2006-10-15 00:25:27 UTC 
Add accessibility keyword.  Apologies for spam.
Comment 4 Rich Burridge 2006-11-16 19:06:19 UTC 
Created attachment 76720 [details] [review]
Patch to hopefully fix the problem.

This is a patch to speechgenerator.py that I think will fix the problem.

The problem is that I can't reproduce the problem, so I need a little
help in testing this. I have NOT checked in this patch to CVS HEAD, so
you will need to save this attachment in a file in the .../orca/src/orca
directory and apply with:

  % patch < patch.319666

This will patch the speechgenerator.py file. Then configure/build/install
Orca as normal.

What the patch does is check for a table cell that is expandable but has
no children. If it finds one, it appends "0 items" to the list of speech
utterances.

Could somebody please give it a try and let me know if it fixes the problem?

Thanks.
Comment 5 Willie Walker 2006-11-30 23:36:27 UTC 
Created attachment 77452 [details] [review]
Patch to also speak empty tables

I did a quick test with this using an empty gaim buddy list as a test.  The problem in that case is that it is a table with no visible children.  This patch seems to catch that well (I tested it).  I'm not sure how to reproduce the other problem described.
Comment 6 Rich Burridge 2006-12-01 00:45:33 UTC 
Umm, did you attach the right patch. This new one looks indentical
to the one that was already there.
Comment 7 Willie Walker 2006-12-01 13:54:51 UTC 
Created attachment 77484 [details] [review]
Patch to also speak empty tables

Here's the real patch (I hope!)
Comment 8 Willie Walker 2006-12-03 11:02:44 UTC 
Created attachment 77571 [details] [review]
Patch to also speak empty layered panes (which I think was the original problem)

I woke up this morning and realized another thing to test would be what happens when encountering empty directories in nautilus.  This new patch helps with that, too.  I test this patch and checked it in for v2.17.3.
Comment 9 Willie Walker 2006-12-03 11:26:58 UTC 
Fixed for v2.17.3.