GNOME Bugzilla – Bug 319379
`make install' will do some compiling work
Last modified: 2016-07-15 11:17:06 UTC
Please describe the problem: ORBit2.12.4 `make' is incomplete, after a `make', if issued `make install' , there are still many compilation to be done, `make install' will do a lot of compilation instead just install Steps to reproduce: 1. ./configure 2. make 3. make install Actual results: `make install' does something should have been done by `make' Expected results: `make install' wont do what `make' should do. Does this happen every time? yes Other information:
Yes - it sucks, it's all to do with the generated IDL dependencies - which are also a royal pain. We need to fix that - but ... it's never seemed that important; If you want to unwind it - you're most welcome - I'd accept a patch that moved all the IDL compilation into a single directory that could be processed early; and that then installed the resulting objects into suitable places. Thanks for the report though.
Created attachment 54142 [details] [review] minimal patch, update only `Makefile.am''s to use `Makefile.idlc' here is a include makefile used to compile idl files. named `Makefile.idlc' changes are made to `Makefile.am''s to use it, it uses timestamp to solve those dependencies, when compile idl files, it firstly use IDL_COMPILER to compile idl to c source files, called `idl-cstamp' then text conversion are done, called `idl-pcstamp' it introduces 3 new dependencies, which are foo.h foo-common.c: foo.idl-pcstamp foo.idl-pcstamp: foo.idl-cstamp foo.idl-cstamp: foo.idl $(IDL_COMPILER) `BUILT_SOURCES' is not neccessary, except if for example `foo.h' is included by some other sourcefiles, like in what happened in `test/' dir. usage: cd ORBit2-2.12.4 gzip -cd < full-patch-ORBit2-2.12.4.gz | patch -p1 ./configure make make check
Please exclude all the generated files when running diff, then the patch will be small enough that you can attach it here in plain text which also makes it easier to review the patch. Makefile, Makefile.in, *.m4, configure and probably some others should be dropped.
Created attachment 70369 [details] [review] edited patch I edited the patch to remove the generated files so the patch is small enough to review.
Created attachment 70370 [details] [review] updated patch Now it applies without rejects too.
The patch scares me. We had a hellish time making it do parallel builds at all [ then again apparently they're broken too ]. Maciej created the original shared Makefile. /me throws up hands in horror. If this chap is confident & responsive, and it works for you, from clean & incrementally with parallel building too - then I'm happy for it to go in :-)
Sorry for letting this hang so long. I only now found out that Makefile.idlc is missing from the patch. Any chance you could update the patch against the current source? I'm attaching an udpated patch here in case that makes it easier for you.
Created attachment 99324 [details] [review] updated patch
Looks nice to me - if it passes make distcheck - I'm a happy man :-) please do commit.
Closing as obsolete.