After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319056 - x-evolution-any-field shortcut doesn't work
x-evolution-any-field shortcut doesn't work
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.4.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks: 327516
 
 
Reported: 2005-10-17 11:30 UTC by Ross Burton
Modified: 2006-06-07 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix x-evolution-any-field serialisation (567 bytes, patch)
2005-10-17 11:32 UTC, Ross Burton 		needs-work Details | Review

Description Ross Burton 2005-10-17 11:30:52 UTC 
EDS supports a special query to return all Contacts.  By defining this is a
standard query for all contacts, it can be special cased:

(contains "x-evolution-any-field" "")

However, this doesn't work.  When that EBookQuery is created and then turned
back into a string, it ends up as this:

(contains "x-evolution-any-field"  "")

Note the extra space near the end.  This means that all of the server-side
optimisations fail, and the contact is matches against a filter which will
always pass.
Comment 1 Ross Burton 2005-10-17 11:32:31 UTC 
Created attachment 53578 [details] [review]
Fix x-evolution-any-field serialisation

The query-to-string code is full of extra spaces (due to building using printf
and escape_string() adding a leading space) but this is the only string which
is compared literally.
Comment 2 André Klapper 2006-02-09 20:18:30 UTC 
adding dep
Comment 3 Harish Krishnaswamy 2006-06-07 08:34:33 UTC 
The patch looks good to commit - include a Change Log. Please include ChangeLogs in patches submitted - helps in easier backporting.
Comment 4 Ross Burton 2006-06-07 11:20:06 UTC 
Applied to HEAD, thanks.