GNOME Bugzilla – Bug 318958
Spaces before/after username should be ignored
Last modified: 2010-06-04 19:54:51 UTC
People often hit a space to get the screen to turn on. This space in the login manager's input field is nearly invisible, but causes login to fail. Since spaces are illegal in usernames anyway, they should be ignored when typed into this field. Other information:
I'd accept a patch to fix this.
Created attachment 66199 [details] [review] don't allow spaces in username This patch catches insert-text for username entry widget to prevents spaces to appear in username; so it is safe again to hit space to wake up the screen.
Frederic. Thanks for the patch. I notice that this patch contains some additional code changes to gdmconfig.c that seem to allow the user to set GDM_KEY_GRAPHICAL_THEME_DIR differently. You don't mention this code change in your comment. Could you explain what this code does and whether you think it should also be put into GDM CVS head? Or were these changes included in the patch by accicent? Note I would only accept a patch to change the behavior of how GDM_KEY_GRAPHICAL_THEME_DIR works if the documentation for the key in the docs/C/gdm.xml file were also updated. Please provide a new patch with docs updates if you intend for this change to go in. Thanks, Brian
Created attachment 75597 [details] [review] Don't let space as first character in username Brian, sorry I kind of forgot about this bug/patch. Here it is updated, removing changes to gdmconfig.c (which were unrelated, incomplete and I have not yet finished).
Note that both gdmlogin and gdmgreeter have a key_release_event (pam_key_release_event for gdmgreeter). Wouldn't it be a bit cleaner to set up a key_press_event and just not accept the space? Or what's the advantage of doing it this way?
Thanks for taking the time to report this bug. However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use. By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME. Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.