After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 318689 - gnome-system-log freezes if /dev/tty* is in /etc/syslog.conf
gnome-system-log freezes if /dev/tty* is in /etc/syslog.conf
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: logview
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
: 320981 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-10-12 16:13 UTC by Frederic Crozat
Modified: 2005-11-13 08:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
only accept regular files as logfile (1.55 KB, patch)
2005-10-12 16:14 UTC, Frederic Crozat 		committed Details | Review

Description Frederic Crozat 2005-10-12 16:13:25 UTC 
Distribution/Version: Mandriva cooker

try adding 
*.* /dev/tty12
to /etc/syslog.conf

and start gnome-system-log : it will freeze because it tries to read the file
entirely (which will never since it is a character device).

The attached patch fixes the problem.
Comment 1 Frederic Crozat 2005-10-12 16:14:51 UTC 
Created attachment 53376 [details] [review]
only accept regular files as logfile
Comment 2 Vincent Noel 2005-10-13 12:33:18 UTC 
Thanks a bunch, please commit your patch to HEAD and the gnome-2-12 branch :-)
Comment 3 Frederic Crozat 2005-10-13 13:00:16 UTC 
committed on HEAD and gnome-2-12 branch.

I've also taken the liberty to fix a small error in HEAD branch in isLogFile
where gnome_vfs_close was called if gnome_vfs_open failed (which was crashing
and was obviously incorrect, probably a bad copy/paste :)
Comment 4 Vincent Noel 2005-10-13 13:14:24 UTC 
Take all the liberties you want ;)
Comment 5 Vincent Noel 2005-11-13 08:48:06 UTC 
*** Bug 320981 has been marked as a duplicate of this bug. ***