After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 318660 - [faac] missing unrefs
[faac] missing unrefs
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.9.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-10-12 11:21 UTC by Josef Zlomek
Modified: 2005-10-12 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Unref faac (6.91 KB, patch)
2005-10-12 11:22 UTC, Josef Zlomek
committed Details | Review

Description Josef Zlomek 2005-10-12 11:21:53 UTC
faac uses gst_pad_get_parent, which refs the faac plugin, but forgets to unref

The attached patch fixes this.
Comment 1 Josef Zlomek 2005-10-12 11:22:45 UTC
Created attachment 53363 [details] [review]
Unref faac
Comment 2 Tim-Philipp Müller 2005-10-12 12:55:44 UTC
Committed, thanks!

Would be great if you could use 'cvs diff -u' in future for patches. Most people
find that patch format easier to read.

2005-10-12  Josef Zlomek  <josef dot zlomek at xeris dot cz>

        * ext/faac/gstfaac.c: (gst_faac_sink_setcaps),
        (gst_faac_src_setcaps), (gst_faac_chain):
          Refcount fixes (#318660)