After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 318447 - gst_bin_iterate_sorted: Invalid call to gst_iterator_new
gst_bin_iterate_sorted: Invalid call to gst_iterator_new
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal critical
: 0.9.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-10-10 12:32 UTC by Josef Zlomek
Modified: 2005-10-10 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch with bug fix (1.04 KB, patch)
2005-10-10 12:32 UTC, Josef Zlomek
committed Details | Review

Description Josef Zlomek 2005-10-10 12:32:01 UTC
The call to gst_iterator_new in gst_bin_iterate_sorted is invalid - the
parameters size and type are in the wrong order.
The first parameter should be the size, the second should be the type.

The attached patch fixes this.
Comment 1 Josef Zlomek 2005-10-10 12:32:36 UTC
Created attachment 53289 [details] [review]
Patch with bug fix
Comment 2 Tim-Philipp Müller 2005-10-10 15:33:51 UTC
Nice catch, thanks for the patch!

2005-10-10  Tim-Philipp Muller  <tim at centricular dot net>

        * gst/gstiterator.c: (gst_iterator_new):
          Add assertions to make sure passed GType is likely to really
          be a GType (as the compiler won't catch it if the size and
          GType arguments get mixed up, see #318447).

2005-10-10  Josef Zlomek  <josef dot zlomek at xeris dot cz>

        * gst/gstbin.c: (gst_bin_iterate_sorted):
          Pass GType and size arguments to gst_iterator_new() in the right
          order (maybe we should make _new() take the GType as first argument
          just like _new_list()?) (#318447).