GNOME Bugzilla – Bug 317609
respect /apps/panel/global/disable_lock_screen
Last modified: 2009-08-12 09:44:00 UTC
Luca Ferretti pointed out: Lock screen lockdown not respected The GConf key /apps/panel/global/disable_lock_screen is used to remove Lock Screen entries from panels. Setting its mandatory value to TRUE, admins can prevent users to lock their screens. But using gnome-screensaver, you can lock the screen even if /apps/gnome-screensaver/lock is TRUE, just activating the lock feature in gnome-screensaver and waiting X minutes. This is not coherent.
Maybe we should move all generic lockdown keys somewhere else...
Vincent, how about moving it to /desktop/gnome/lockdown/disable_lock_screen ?
Makes sense. I'd like to move more lockdown settings there, in fact. I hope we'll get a SoC project on lockdown so someone can think and make the good choices. But yes, it makes sense.
I want to code it. But, using /apps/panel/global/disable_lock_screen, /apps/gnome-screensaver/lock or /desktop/gnome/lockdown/disable_lock_screen?
I see that /apps/gnome-screensaver/lock doesn't exist. The real name of the key is /apps/gnome-screensaver/lock_enabled . No???
Or... Must I add the two keys in gconf to test this issue?
Hi Bruno, Thanks for taking a look at this :) If Vincent agrees, I think a plan might be: * Make gnome-panel use /desktop/gnome/lockdown/disable_lock_screen instead of /apps/panel/global/disable_lock_screen (and maybe even move other panel lockdown keys?) * Make gnome-screensaver use that key
So, I'm waiting for Vincent's comment about this.
Oh... I see that gnome-panel is using /desktop/gnome/lockdown/disable_lock_screen. See the code in gnome-panel/gnome-panel/panel-lockdown.c : ... #define PANEL_GLOBAL_LOCKDOWN_DIR "/apps/panel/global" #define DESKTOP_GNOME_LOCKDOWN_DIR "/desktop/gnome/lockdown" #define PANEL_GLOBAL_LOCKED_DOWN_KEY PANEL_GLOBAL_LOCKDOWN_DIR "/locked_down" ... So, I'm ready to start implement this. What you think disable the checkbox "Lock screen when screensaver is active" in gnome-screensaver's preferences when /desktop/gnome/lockdown/disable_lock_screen is TRUE too?
Sorry... I made a mistake... gnome-panel still using /apps/panel/global
(In reply to comment #7) > Hi Bruno, > > Thanks for taking a look at this :) > > If Vincent agrees, I think a plan might be: Can you contact Vincent to check his opinion? I'd like to work in lockdown project (mentioned by Vincent) too. > > * Make gnome-panel use /desktop/gnome/lockdown/disable_lock_screen instead of > /apps/panel/global/disable_lock_screen (and maybe even move other panel > lockdown keys?) > * Make gnome-screensaver use that key >
As lock screen is a desktop wide feature, we should have a common key to handle that. I submited a bug to libgnome (bug 386864) as i already did for user switching (bug 385119)
Where does it to be fixed ? From the preferences or anywhere else (gs-manager maybe ?) ? So, do we have to add a new variable in gsPrefs or just modify GSPrefs.lock_enabled ?
herlock: the proposed key would work a bit different than the gnome-screensaver lock_enabled key. The g-s lock_enabled key is used to determine if the screen should be locked in addition to blanking when the computer becomes idle. It isn't involved when the screensaver is specifically asked to lock (eg. by using gnome-screensaver --lock). This proposed key would disable locking altogether and cause gnome-screensaver --lock to fail with an error message.
ping :-) Almost one year and nothing new...
Created attachment 100842 [details] [review] Patch for gnome-panel to respect /desktop/gnome/lockdown/disable_lock_screen
Created attachment 100843 [details] [review] Patch for gnome-screensaver to respect /desktop/gnome/lockdown/disable_lock_screen Ctrl-Alt-L and gnome-screensaver --lock do not function when /desktop/gnome/lockdown/disable_lock_screen is enabled. The checkbox in gnome-screensaver-preferences for the lock is greyed out when the key is enabled, too.
Sorry for the really long delay. The patch looks quite good. I've committed this to trunk with a few small changes. I've removed the changes to gs-manager and reused the existing lock-enabled property. Thanks! I'll move this to gnome-panel for the other part.
Finally fixed, thanks!