After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317609 - respect /apps/panel/global/disable_lock_screen
respect /apps/panel/global/disable_lock_screen
Product: gnome-panel
Classification: Other
Component: general
git master
Other Linux
: High normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on: 386864
Reported: 2005-09-30 15:11 UTC by William Jon McCann
Modified: 2009-08-12 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch for gnome-panel to respect /desktop/gnome/lockdown/disable_lock_screen (886 bytes, patch)
2007-12-12 18:39 UTC, nickspoon0
committed Details | Review
Patch for gnome-screensaver to respect /desktop/gnome/lockdown/disable_lock_screen (12.09 KB, patch)
2007-12-12 18:48 UTC, nickspoon0
committed Details | Review

Description William Jon McCann 2005-09-30 15:11:01 UTC
Luca Ferretti pointed out:

Lock screen lockdown not respected

        The GConf key /apps/panel/global/disable_lock_screen is used to
        remove Lock Screen entries from panels. Setting its mandatory
        value to TRUE, admins can prevent users to lock their screens.
        But using gnome-screensaver, you can lock the screen even
        if /apps/gnome-screensaver/lock is TRUE, just activating the
        lock feature in gnome-screensaver and waiting X minutes. This is
        not coherent.
Comment 1 Vincent Untz 2006-03-03 18:02:27 UTC
Maybe we should move all generic lockdown keys somewhere else...
Comment 2 William Jon McCann 2006-04-24 17:11:25 UTC
Vincent, how about moving it to /desktop/gnome/lockdown/disable_lock_screen ?
Comment 3 Vincent Untz 2006-04-24 21:34:29 UTC
Makes sense. I'd like to move more lockdown settings there, in fact. I hope we'll get a SoC project on lockdown so someone can think and make the good choices.

But yes, it makes sense.
Comment 4 Bruno Boaventura 2006-09-20 10:46:27 UTC
I want to code it. But, using /apps/panel/global/disable_lock_screen, /apps/gnome-screensaver/lock or /desktop/gnome/lockdown/disable_lock_screen?
Comment 5 Bruno Boaventura 2006-09-27 00:16:43 UTC
I see that /apps/gnome-screensaver/lock doesn't exist. The real name of the key is /apps/gnome-screensaver/lock_enabled . No???
Comment 6 Bruno Boaventura 2006-09-27 00:22:40 UTC
Or... Must I add the two keys in gconf to test this issue?
Comment 7 William Jon McCann 2006-09-27 00:28:45 UTC
Hi Bruno,

Thanks for taking a look at this :)

If Vincent agrees, I think a plan might be:

* Make gnome-panel use /desktop/gnome/lockdown/disable_lock_screen instead of /apps/panel/global/disable_lock_screen (and maybe even move other panel lockdown keys?)
* Make gnome-screensaver use that key
Comment 8 Bruno Boaventura 2006-09-27 21:27:45 UTC
So, I'm waiting for Vincent's comment about this.
Comment 9 Bruno Boaventura 2006-09-27 22:00:57 UTC
Oh... I see that gnome-panel is using /desktop/gnome/lockdown/disable_lock_screen.
See the code in gnome-panel/gnome-panel/panel-lockdown.c :

#define PANEL_GLOBAL_LOCKDOWN_DIR    "/apps/panel/global"
#define DESKTOP_GNOME_LOCKDOWN_DIR   "/desktop/gnome/lockdown"

So, I'm ready to start implement this.

What you think disable the checkbox "Lock screen when screensaver is active" in gnome-screensaver's preferences when /desktop/gnome/lockdown/disable_lock_screen is TRUE too?
Comment 10 Bruno Boaventura 2006-09-27 22:07:33 UTC
Sorry... I made a mistake... gnome-panel still using /apps/panel/global
Comment 11 Bruno Boaventura 2006-11-10 04:47:37 UTC
(In reply to comment #7)
> Hi Bruno,
> Thanks for taking a look at this :)
> If Vincent agrees, I think a plan might be:

Can you contact Vincent to check his opinion?
I'd like to work in lockdown project (mentioned by Vincent) too.

> * Make gnome-panel use /desktop/gnome/lockdown/disable_lock_screen instead of
> /apps/panel/global/disable_lock_screen (and maybe even move other panel
> lockdown keys?)
> * Make gnome-screensaver use that key

Comment 12 Guillaume Desmottes 2006-12-17 17:57:29 UTC
As lock screen is a desktop wide feature, we should have a common key to handle that.
I submited a bug to libgnome (bug 386864) as i already did for user switching (bug 385119)
Comment 13 Gaëtan Podevijn 2006-12-20 20:59:17 UTC
Where does it to be fixed ? From the preferences or anywhere else (gs-manager maybe ?) ?

So, do we have to add a new variable in gsPrefs or just modify GSPrefs.lock_enabled ? 
Comment 14 William Jon McCann 2006-12-20 21:07:11 UTC
herlock: the proposed key would work a bit different than the gnome-screensaver lock_enabled key.

The g-s lock_enabled key is used to determine if the screen should be locked in addition to blanking when the computer becomes idle.  It isn't involved when the screensaver is specifically asked to lock (eg. by using gnome-screensaver --lock).

This proposed key would disable locking altogether and cause gnome-screensaver --lock to fail with an error message.
Comment 15 Luis Menina 2007-12-11 13:10:41 UTC
ping :-)
Almost one year and nothing new...
Comment 16 nickspoon0 2007-12-12 18:39:00 UTC
Created attachment 100842 [details] [review]
Patch for gnome-panel to respect /desktop/gnome/lockdown/disable_lock_screen
Comment 17 nickspoon0 2007-12-12 18:48:07 UTC
Created attachment 100843 [details] [review]
Patch for gnome-screensaver to respect /desktop/gnome/lockdown/disable_lock_screen

Ctrl-Alt-L and gnome-screensaver --lock do not function when /desktop/gnome/lockdown/disable_lock_screen is enabled. The checkbox in gnome-screensaver-preferences for the lock is greyed out when the key is enabled, too.
Comment 18 William Jon McCann 2008-08-21 01:46:06 UTC
Sorry for the really long delay.  The patch looks quite good.  I've committed this to trunk with a few small changes.  I've removed the changes to gs-manager and reused the existing lock-enabled property.  Thanks!

I'll move this to gnome-panel for the other part.
Comment 19 Vincent Untz 2009-08-12 09:44:00 UTC
Finally fixed, thanks!