After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317190 - [PATCH] Use intltool for translation management
[PATCH] Use intltool for translation management
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2005-09-25 22:54 UTC by Rodney Dawes
Modified: 2005-09-29 07:46 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch to add intltool support and fix other issues (2.36 KB, patch)
2005-09-25 22:54 UTC, Rodney Dawes
committed Details | Review

Description Rodney Dawes 2005-09-25 22:54:27 UTC
The attached patch adds support for intltool to libwnck. It also fixes a few
other issues I found. AC_ARG_PROGRAM already gets called, so we don't need to
explicitly call it. The AC_DEFINE calls need to have a description as the third
argument. By doing this, we can remove acconfig.h which removes a warning from
autoheader.
Comment 1 Rodney Dawes 2005-09-25 22:54:58 UTC
Created attachment 52643 [details] [review]
Patch to add intltool support and fix other issues
Comment 2 Vincent Untz 2005-09-29 07:46:56 UTC
Thanks, I committed most of your patch.

From http://www.gnu.org/prep/standards/html_node/Standard-Targets.html:

‘maintainer-clean’
    Delete almost everything that can be reconstructed with this Makefile. This
typically includes everything deleted by distclean, plus more: C source files
produced by Bison, tags tables, Info files, and so on.

    The reason we say “almost everything” is that running the command ‘make
maintainer-clean’ should not delete configure even if configure can be remade
using a rule in the Makefile. More generally, ‘make maintainer-clean’ should not
delete anything that needs to exist in order to run configure and then begin to
build the program. Also, there is no need to delete parent directories that were
created with ‘mkdir -p’, since they could have existed anyway. These are the
only exceptions; maintainer-clean should delete everything else that can be
rebuilt.