After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 316042 - Custom Icons on folders do not show in folder's window/taskbar icon
Custom Icons on folders do not show in folder's window/taskbar icon
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: [obsolete] Backgrounds Emblems and Themes
2.16.x
Other All
: Normal enhancement
: 2.16.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 354628 (view as bug list)
Depends on:
Blocks: 619791
 
 
Reported: 2005-09-12 02:35 UTC by n0dalus
Modified: 2010-07-11 00:44 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Update window icon to that of the folder currently showing (#316042) (1.93 KB, patch)
2010-07-10 22:41 UTC, Marcus Carlson
rejected Details | Review

Description n0dalus 2005-09-12 02:35:55 UTC
When you set a custom icon on a folder (and or emblems), and then open that
folder, the taskbar/window icon is still a plain icon, but it should be the icon
that you set it to be in the parent folder.
Comment 1 Christian Neumair 2005-09-12 09:58:32 UTC
Thanks for your bug report! This sounds like a improvement suggestion.
Comment 2 Christian Neumair 2005-09-12 10:32:00 UTC
Just some info for the developers: I've done a bit hacking.
nautilus_window_update_icon just does a set_icon_name, but should also be able
to take a pixbuf from the icon factory. We currently only lookup a name in the
icon factory (NautilusWindow::get_icon_name for NautilusSpatialWindow). We may
want to add a icon_factory_get_custom_icon_or_icon_name helper, which returns
either a custom icon (if available), or the name of a looked up named icon. This
pixbuf should then be propagated down to nautilus_window_update_icon.
Milestoning to 2.14 since it requires quiet some code changes and potentially
breaks UI freeze.
Comment 3 Christian Neumair 2005-10-03 12:29:19 UTC
Mass changing Nautilus version for bugs that have GNOME 2.13 version info.
Comment 4 Sebastien Bacher 2006-05-10 14:04:31 UTC
Ubuntu bug about that: https://launchpad.net/products/nautilus/+bug/43608
Comment 5 David Prieto 2006-08-02 12:22:42 UTC
Well this was milestoned for 2.14... do you think it's going to be taken care of before 2.16?
Comment 6 Sergej Kotliar 2006-09-06 14:49:10 UTC
*** Bug 354628 has been marked as a duplicate of this bug. ***
Comment 7 Daniel Holbach 2006-09-29 13:46:39 UTC
2.18 maybe.
Comment 8 Marcus Carlson 2010-07-10 22:41:46 UTC
Created attachment 165650 [details] [review]
Update window icon to that of the folder currently showing (#316042)
Comment 9 Cosimo Cecchi 2010-07-11 00:20:43 UTC
This has already been fixed some time ago, can't find the commit right now though.