GNOME Bugzilla – Bug 314843
[patch]gnome-vfs-cdrom.c Irix compile problem
Last modified: 2005-11-26 13:46:01 UTC
Please describe the problem: The file libgnome/gnome-vfs-cdrom.c cannot be compiled on Irix (and probably other systems too) because unknown systems are assumed to be Linux. Steps to reproduce: Try to compile on a system which is nither of: Solaris, OSX, FreeBSD, OpenBSD, NetBSD or Linux. Actual results: The compiler stops because the linux specific constants CDROM_DRIVE_STATUS, CDSL_CURRENT, CDS_DISC_OK and CDROM_DISK_STATUS are undefined. Expected results: I would at least excpect it to compile, but even better, actually work on Irix too. Does this happen every time? Yes Other information:
Created attachment 51558 [details] [review] Irix compile fix This patch fixes _gnome_vfs_get_cdrom_type() so that the linux code is used only on Linux (__linux__ is defined). If the system is unknown the function just returns CDS_NO_INFO (like it does for OSX). I knew how to I would implement this function for Irix. But hey, at least it compiles.
adding build keyword. confirming since we have a patch.
This is the same problem as in bug #171495, which is already fix. Thanks anyway. *** This bug has been marked as a duplicate of 171495 ***