After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314843 - [patch]gnome-vfs-cdrom.c Irix compile problem
[patch]gnome-vfs-cdrom.c Irix compile problem
Status: RESOLVED DUPLICATE of bug 171495
Product: gnome-vfs
Classification: Deprecated
Component: Build
2.10.x
Other All
: Normal normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-30 15:13 UTC by Magnus Bergman
Modified: 2005-11-26 13:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Irix compile fix (598 bytes, patch)
2005-08-30 15:20 UTC, Magnus Bergman
none Details | Review

Description Magnus Bergman 2005-08-30 15:13:00 UTC
Please describe the problem:
The file libgnome/gnome-vfs-cdrom.c cannot be compiled on Irix (and probably
other systems too) because unknown systems are assumed to be Linux.

Steps to reproduce:
Try to compile on a system which is nither of: Solaris, OSX, FreeBSD, OpenBSD,
NetBSD or Linux.


Actual results:
The compiler stops because the linux specific constants CDROM_DRIVE_STATUS,
CDSL_CURRENT, CDS_DISC_OK and CDROM_DISK_STATUS are undefined.

Expected results:
I would at least excpect it to compile, but even better, actually work on Irix too.

Does this happen every time?
Yes

Other information:
Comment 1 Magnus Bergman 2005-08-30 15:20:33 UTC
Created attachment 51558 [details] [review]
Irix compile fix

This patch fixes _gnome_vfs_get_cdrom_type() so that the linux code is used
only on Linux (__linux__ is defined). If the system is unknown the function
just returns CDS_NO_INFO (like it does for OSX). I knew how to I would
implement this function for Irix. But hey, at least it compiles.
Comment 2 Christian Kirbach 2005-09-03 16:16:33 UTC
adding build keyword.

confirming since we have a patch.
Comment 3 Christian Kellner 2005-11-26 13:46:01 UTC
This is the same problem as in bug #171495, which is already fix. Thanks anyway.

*** This bug has been marked as a duplicate of 171495 ***