After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314316 - Rotate thumbnails with document
Rotate thumbnails with document
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Urgent blocker
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks: 312019
 
 
Reported: 2005-08-23 21:36 UTC by Nickolay V. Shmyrev
Modified: 2005-08-25 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (10.65 KB, patch)
2005-08-23 21:39 UTC, Nickolay V. Shmyrev 		none Details | Review
Updated patch (11.21 KB, patch)
2005-08-23 21:52 UTC, Nickolay V. Shmyrev 		none Details | Review
Patch to fix 1. (3.56 KB, patch)
2005-08-24 15:33 UTC, Nickolay V. Shmyrev 		committed Details | Review
Patch to fix 2. (7.08 KB, patch)
2005-08-24 15:34 UTC, Nickolay V. Shmyrev 		none Details | Review

Description Nickolay V. Shmyrev 2005-08-23 21:36:11 UTC 
There are three problem with rotation I'd like to solve before release

1. Djvu, tiff, pixbuf and dvi rotate document left when user select "Rotate right".

2. Thumbnails are not rotated

3. Ps document isn't rotated also
Comment 1 Nickolay V. Shmyrev 2005-08-23 21:39:27 UTC 
Created attachment 51217 [details] [review]
Patch

this patch should solve problems 1 and 2, but I am still wondering why we
should change rotation direction in backend. Isn't it better to fix poppler so
it's rotation will match natural direction.

About problem 3 I can't quickly find a way to solve it.
Comment 2 Nickolay V. Shmyrev 2005-08-23 21:52:22 UTC 
Created attachment 51218 [details] [review]
Updated patch

This patch should also fix problem number 3, thus all visible for me problems.
Although it looks a bit hackish for me.
Comment 3 Jonathan Blandford 2005-08-24 04:03:26 UTC 
This fixes some problems, but doesn't seem to fully work.  I'll have another
look later.
Comment 4 Marco Pesenti Gritti 2005-08-24 09:55:07 UTC 
I fixed 3 in cvs in a non hacky way. With the testcase I'm using I still get
rendering problems but it seem like a gs problem (same result in ggv).

About 1 I'm not sure... postscript seem to use the same rotation logic as
poppler. So maybe we should stick with that? Or would it be better to be
consistent with gtk logic?

About 2 I dont think it's a critical problem, unless we have a not too risky
patch we should probably delay it (up to jrb anyway).
Comment 5 Nickolay V. Shmyrev 2005-08-24 13:54:02 UTC 
Well, if problem 3 is fixed then first patch from comment #1 should be aplied
instead
Comment 6 Nickolay V. Shmyrev 2005-08-24 15:33:50 UTC 
Created attachment 51267 [details] [review]
Patch to fix 1.
Comment 7 Nickolay V. Shmyrev 2005-08-24 15:34:20 UTC 
Created attachment 51268 [details] [review]
Patch to fix 2.
Comment 8 Nickolay V. Shmyrev 2005-08-24 15:46:20 UTC 
1 and 3 fixed, only 2 left
Comment 9 Nickolay V. Shmyrev 2005-08-25 20:03:02 UTC 
Should be fixed now. Thanks to all