After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314079 - configure.in doesnt check for Xauth existence and usability
configure.in doesnt check for Xauth existence and usability
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
: 362050 362559 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-08-21 12:52 UTC by Claudio Saavedra
Modified: 2006-11-13 21:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch. (1.13 KB, patch)
2005-08-21 12:55 UTC, Claudio Saavedra
committed Details | Review
use X linking flags, so Xauth in /usr/X11R6/libs/ will be found. (657 bytes, patch)
2006-11-01 18:16 UTC, Frederic Peters
committed Details | Review

Description Claudio Saavedra 2005-08-21 12:52:09 UTC
Due to the dependence from gnome-session on Xauth, configure.in must test if
this library is installed in the system.

When I was building gnome-session, the build failed due to a undefined reference
to XauDisposeAuth. The problem was that I haven't had Xauth library installed,
but the configure script didn't notice it.
Comment 1 Claudio Saavedra 2005-08-21 12:55:55 UTC
Created attachment 51059 [details] [review]
Proposed patch.

Simple check for the existence of the header file.
Comment 2 Kjartan Maraas 2006-05-24 12:14:08 UTC
You could improve the error message: "You must install the Xauth library and headers to compile gnome-session." or something along those lines. Vincent, can this go in with that change?
Comment 3 Claudio Saavedra 2006-06-30 10:21:52 UTC
No problem. I can improve it. Just waiting for Vincent comment.
Comment 4 Tom Tromey 2006-09-30 04:00:21 UTC
FWIW this patch (with an update to the text) looks reasonable to me.
(In general it doesn't make sense to check for required headers --
IMO having the build fail is just as good as having configure fail.
But I don't think it matters much either way...)
Comment 5 Vincent Untz 2006-10-08 15:13:53 UTC
I committed a similar patch.
Comment 6 christopher taylor 2006-10-14 14:08:43 UTC
The patch is erroneous. It's missing a final parenthesis. 
])]) instead of )]]
Comment 7 christopher taylor 2006-10-14 14:32:18 UTC
Another problem I have is that configure doesn't look for libXau in "/usr/X11/lib" and I'll not pass this test. I guess a LIBS variable is missing.
Comment 8 Tom Tromey 2006-10-14 23:15:40 UTC
Reopening; see comment #6 and comment #7.
Comment 9 Tom Tromey 2006-10-14 23:16:09 UTC
*** Bug 362050 has been marked as a duplicate of this bug. ***
Comment 10 Tom Tromey 2006-10-14 23:17:03 UTC
Bug #362050 has the same fix as a patch, fwiw.
Comment 11 Tom Tromey 2006-10-18 06:27:50 UTC
*** Bug 362559 has been marked as a duplicate of this bug. ***
Comment 12 Tom Tromey 2006-10-22 19:11:27 UTC
Was fixed by the commit for bug #362541.


*** This bug has been marked as a duplicate of 362541 ***
Comment 13 Frederic Peters 2006-11-01 18:15:31 UTC
comment #7 still applies; 

http://jhbuild.bxlug.be/builds/2006-11-01-0000/logs/gnome-session/#configure

(patch to follow)
Comment 14 Frederic Peters 2006-11-01 18:16:42 UTC
Created attachment 75785 [details] [review]
use X linking flags, so Xauth in /usr/X11R6/libs/ will be found.

use X linking flags, so Xauth in /usr/X11R6/libs/ will be found.
Comment 15 Vincent Untz 2006-11-13 21:13:37 UTC
Thanks.