GNOME Bugzilla – Bug 313753
Expansion of NEON_SSL breaks configure
Last modified: 2005-08-23 15:27:52 UTC
./configure crashes on sytems with latest neon installed. This is because of this: The imported version of neon uses NEON_SSL as #define. But current version has an Autoconf macro with the same name. When m4 files with this macro are installed in the aclocal directory, this breaks the AC_DEFINE call which is used in acinclude.m4.
Created attachment 50868 [details] [review] a patch This ugly hack fixes the problem. (Of course, the problem will disappear as soon as ./imported/neon will be replaced by current version and acinclude.m4 will hold current neon macros.)
Created attachment 50869 [details] [review] various fixes in configure.in When I was sniffing in configure.in, I corrected some m4 quoting, one typo (--enable-http_neon), and many various cosmetic changes. OK to commit?
One more comment: To reproduce the problem as described here, you need aclocal from Automake >= 1.8. With aclocal < 1.8, acinclude.m4 was placed at the beginning of aclocal.m4, and thus LIBNEON_SOURCE_CHECKS was redefined by the definition in neon.m4. This wasn't healthy either: NEON_SSL was never defined in config.h, and the ssl code in neon was not compiled.
Ohh gosh autocrap. Thanks. Looks good to me. Well as good as autocrap foo can look anyway.
It can, but it takes some work. If TFM is not enough, feel free to ask us at gnu.org Autoconf list. ;-) Committed.