GNOME Bugzilla – Bug 313554
Some translatable messages in the itip-formatter plugin are not marked for translation
Last modified: 2013-09-10 14:01:56 UTC
Please describe the problem: In plugins/itip-formatter/itip-formatter.c, the following user-visible messages are not marked for translation: in function 'static void find_cal_opened_cb': Found the appointment in the calendar '%s' An appointment in the calendar '%s' conflicts with this meeting Unable to find this meeting in any calendar Unable to find this task in any task list Unable to find this journal entry in any journal in function 'static void find_server' Searching for an existing version of this appointment in file plugins/itip-formatter/itip-view.c all the strings contained by function 'static void set_buttons' are not marked for translation. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
adding keywords and deps
Created attachment 51376 [details] [review] untested patch fixes those issues, haven't tested, misses changelog (sorry), don't know if there has to be some "#include"... :-/
this should be at least included in 2.5, setting milestone
*poke* please review and commit both to 2.4 and 2.5 branch. this is allowed according to the guidelines because these are formerly untranslated, but included strings.
Created attachment 56524 [details] [review] updated patch attaching this updated patch here to get it into 2.4.3 (i'm currently way to stoopid to do that); also retargetting. as already written it IS allowed to commit this to the stable branch. i already committed this to HEAD: http://cvs.gnome.org/viewcvs/evolution/plugins/itip-formatter/itip-formatter.c?r1=1.55&r2=1.56 http://cvs.gnome.org/viewcvs/evolution/plugins/itip-formatter/itip-view.c?r1=1.19&r2=1.20 **This fix was written at the Evolution Team Germany conference and meeting.**
dumdidum.
i went ahead and also fixed this in gnome-2-12 branch, so the strings will be translatable for evo 2.4.3: http://cvs.gnome.org/viewcvs/evolution/plugins/itip-formatter/itip-formatter.c?r1=1.53&r2=1.53.2.1 http://cvs.gnome.org/viewcvs/evolution/plugins/itip-formatter/itip-view.c?r1=1.17.2.1&r2=1.17.2.2 i don't know if we should seperately inform the translators list, though. harish?
Yes, please drop a mail to gnome-i18n list, we translators like to be informed about changes like this. (as explained at: http://mail.gnome.org/archives/desktop-devel-list/2005-February/msg00092.html )
gabor, thanks for your posting. though i thought that i already knew that mail by menthos by hard, i indeed discovered the section "The following types of changes do not need explicit approval, however we would still very much like them to be announced so that we know about them: * Marking a message for translation that was previously not marked for translation by accident." okay, will do. thanks very much for pointing me on this.