After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312780 - Add undo to foreground selection tool
Add undo to foreground selection tool
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: High enhancement
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
: 499690 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-08-06 21:09 UTC by Sven Neumann
Modified: 2014-04-18 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
current state of work (11.95 KB, patch)
2005-08-06 21:10 UTC, Sven Neumann 		rejected Details | Review

Description Sven Neumann 2005-08-06 21:09:36 UTC 
The new foreground selection tool should provide undo functionality, allowing
the user to undo and redo the refinements made to the selection. I have this
implemented to some extent but the integration with the undo system as outlined
in this patch doesn't work. We will probably need to extend the undo system in
order to make this work. I am attaching my current changes so that they don't
get lost.
Comment 1 Sven Neumann 2005-08-06 21:10:20 UTC 
Created attachment 50331 [details] [review]
current state of work
Comment 2 Sven Neumann 2007-11-26 08:00:06 UTC 
*** Bug 499690 has been marked as a duplicate of this bug. ***
Comment 3 Michael Natterer 2013-11-17 00:03:48 UTC 
Now easily possible with the new tool undo infrastructure, we should
add this when fixing the tool for 2.10.
Comment 4 Michael Natterer 2013-11-17 00:04:45 UTC 
Comment on attachment 50331 [details] [review]
current state of work

This patch is now useless though.
Comment 5 Michael Natterer 2014-04-18 22:37:27 UTC 
Fixed in master:

commit 6ec272fde7f978369b11fbd8767b669f8dac716f
Author: Michael Natterer <mitch@gimp.org>
Date:   Sat Apr 19 00:34:21 2014 +0200

    Bug 312780 - Add undo to foreground selection tool
    
    Implement undoing strokes by keeping copies of the changed parts
    of the trimap around in internal undo/redo stacks.

 app/tools/gimpforegroundselecttool.c | 265 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 app/tools/gimpforegroundselecttool.h |   3 +
 2 files changed, 260 insertions(+), 8 deletions(-)