After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312238 - Should depend explicitly on glib-2.0 >= 2.7.0
Should depend explicitly on glib-2.0 >= 2.7.0
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal trivial
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-01 13:44 UTC by Leonardo Boshell
Modified: 2005-08-03 05:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
evince-HEAD-glib_dep.patch (1.30 KB, patch)
2005-08-01 13:45 UTC, Leonardo Boshell 		none Details | Review

Description Leonardo Boshell 2005-08-01 13:44:35 UTC 
shell/ev-window.c calls g_file_set_contents(), a function that is available
since glib-2.7.0.

It would be nice to add the corresponding check in the configure script. I'll
attach the small patch against configure.ac for this in case you want to review it.

Thanks.
Comment 1 Leonardo Boshell 2005-08-01 13:45:08 UTC 
Created attachment 50066 [details] [review]
evince-HEAD-glib_dep.patch
Comment 2 Marco Pesenti Gritti 2005-08-01 16:20:52 UTC 
Hmm not sure what we actually want to do here. We have already several places
where we depend on gtk 2.7, we may either drop all the 2.6 compatibility code or
define out the use of g_file_set_contents() too.

It would be probably good to be able to compile 0.4 with gtk 2.6 too, because
several distributions are shipping 0.3, which was not stable release quality yet.
Comment 3 Marco Pesenti Gritti 2005-08-01 16:26:42 UTC 
We could also copy the g_file_set_contents() code and enable it for 2.6, if it
doesnt have too many dependencies.
Comment 4 Jonathan Blandford 2005-08-02 21:55:55 UTC 
Marco, you convinced me.  Lets get this working with GTK+ 2.6
Comment 5 Nickolay V. Shmyrev 2005-08-03 05:52:31 UTC 
I've copy-pasted glib code and stripped it a bit to drop problems with
translations. This bug should be fixed in CVS.