After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312159 - Pressing cancel in password dialog makes it appear again
Pressing cancel in password dialog makes it appear again
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Module: ftp
cvs (head)
Other Linux
: Normal normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-31 20:26 UTC by Martin Ejdestig
Modified: 2006-03-19 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Martin Ejdestig 2005-07-31 20:26:07 UTC 
When canceling the password dialog it appears a second time and you must press
cancel a second time.

(Same bug for the ssh/sftp module is bug 139832)
Comment 1 Nelson Benitez 2005-09-10 17:19:34 UTC 
And for me, it also shows and error dialog telling that it could not connect,
which should not appear as I chose "Cancel".
Comment 2 Christian Kirbach 2005-10-13 14:52:27 UTC 
same issue with a different method

*** This bug has been marked as a duplicate of 139832 ***
Comment 3 Martin Ejdestig 2005-10-13 15:44:21 UTC 
Uhm... bug 139832 only talks about the sftp module. I agree it can be closed as
a duplicate if it isn't module dependent.
Comment 4 Christian Neumair 2005-10-13 15:48:35 UTC 
It *is* module dependent.
Comment 5 Martin Ejdestig 2005-10-13 15:55:30 UTC 
Ah, sorry. Read my bugzilla mail in the wrong order for this one. ;)

In bug 139832, comment 6 you say that you think it isn't module dependant and
Alex say in bug 139832, comment 1 that it might be. Just curious, what makes you
think Alex is wrong?
Comment 6 Christian Neumair 2005-10-13 19:04:58 UTC 
It's actually both, it's Nautilus and GnomeVFS:

http://mail.gnome.org/archives/gnome-vfs-list/2005-October/msg00006.html
http://mail.gnome.org/archives/nautilus-list/2005-October/msg00063.html

My approach is not yet perfect, but it's a good start. The trick is to make
a) make GnomeVFS always return GNOME_VFS_ERROR_CANCELLED if cancellation
happened (module dependant)
b) make Nautilus "ignore" GNOME_VFS_ERROR_CANCELLED retvals (i.e. stop trying to
display a view for the requested URI, not module dependant)
Comment 7 Martin Ejdestig 2005-10-13 19:12:52 UTC 
Great!

Guess that also takes care of my ramblings in bug 139832, comment 12 then.

I'm quite busy with other stuff at the moment so I can't help by
testing/reviewing any patches. :(
Comment 8 Christian Neumair 2006-03-19 21:19:13 UTC 
We've committed fixes, cf. the URIs referenced in comments 6 :).

Marking as FIXED.