After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312033 - new attachment widget no polished
new attachment widget no polished
Status: RESOLVED OBSOLETE
Product: evolution
Classification: Applications
Component: Mailer
2.6.x (obsolete)
Other Linux
: Normal major
: Future
Assigned To: Srinivasa Ragavan
Evolution QA team
evolution[attachments]
Depends on:
Blocks: 327508 327510
 
 
Reported: 2005-07-30 09:06 UTC by Baptiste Mille-Mathias
Modified: 2009-03-31 04:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
screenshot (37.69 KB, image/png)
2005-07-30 09:11 UTC, Baptiste Mille-Mathias
Details

Description Baptiste Mille-Mathias 2005-07-30 09:06:05 UTC
Version details: 2.3.6.1

the new attachment widget is not polished
1° it doesn't use the whole width of the message [1]
2° it doesn't have border
3° it waste too much space between the bootom of the attachment icon and the
bottom of the attchment widget [1]

[1] see the screenshot attached.
Comment 1 Baptiste Mille-Mathias 2005-07-30 09:11:38 UTC
Created attachment 49967 [details]
screenshot
Comment 2 Baptiste Mille-Mathias 2005-07-30 09:17:37 UTC
set the UI keyword
Comment 3 Srinivasa Ragavan 2005-08-04 09:14:59 UTC
Nice.  Im fixing 'most' of it. But still this is not a blocker
Comment 4 Srinivasa Ragavan 2005-12-21 18:50:58 UTC
It has a border. It now resizes.
Comment 5 Baptiste Mille-Mathias 2006-01-03 20:25:46 UTC
Step 1° is still applicable in evolution 2.5.4 (the widget has a fixed width, and so doesn't take all available width), so i reopen the bug.
Comment 6 Srinivasa Ragavan 2006-01-04 05:06:02 UTC
bapiste, it takes the width, when loading a mail, but doesnt resize after that. It resizes when you choose the next  message. You think it should? Is that what you are meaning?
Comment 7 Baptiste Mille-Mathias 2006-01-04 20:28:31 UTC
Hello Srinivasa, and Happy new year.

I think the width widget should been redrawn as the same manner than the mail widget, so at any moment.
Its better for consistency and for UI.

Thanks.
Comment 8 Srinivasa Ragavan 2006-01-05 04:04:17 UTC
Sorry about my earlier statement,

static void
efhd_bar_resize(GtkWidget *w, GtkAllocation *event, EMFormatHTML *efh)
{
	int width;
	GtkRequisition req;
	EMFormatHTMLDisplay *efhd = (EMFormatHTMLDisplay *) efh;

	gtk_widget_size_request (efhd->priv->attachment_bar, &req);
	width = ((GtkWidget *) efh->html)->allocation.width - 16;
	/* Update the width of the bar */
	e_attachment_bar_set_width(E_ATTACHMENT_BAR(efhd->priv->attachment_bar), width);
}


and....
	g_signal_connect (eb, "size_allocate", G_CALLBACK (efhd_bar_resize), efh);

I remember fixing this and the code is present. It works for me sometimes, but after switching to my widescreen laptop, it seems to have stopped and works random. Anyway ill have a look into this.


Comment 9 Srinivasa Ragavan 2006-01-22 17:05:41 UTC
This seems to be a gtk bug. 50% times, the signal is received and the rest is not.  Try resizing bit faster, it seems to work and doesnt do otherwise.. pretty odd.

Btw howz this a major. Normal was ok imo.
Comment 10 André Klapper 2006-03-22 01:29:48 UTC
removing old 2.5 target milestone and retargetting to future - sorry.
Comment 11 Matthew Barnes 2008-03-11 00:25:53 UTC
Bumping version to a stable release.
Comment 12 Matthew Barnes 2009-03-31 04:37:20 UTC
The resizing seems to work fine in 2.26, and the other issues have been addressed as Srini said, so closing as OBSOLETE.