After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311802 - [PATCH] local variable 'bq' for timestamp conversion uninitialized
[PATCH] local variable 'bq' for timestamp conversion uninitialized
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.8.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-07-27 23:12 UTC by daniel fischer
Modified: 2005-07-28 07:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

initialize bq to { 1, GST_SECOND } (574 bytes, patch)
2005-07-27 23:13 UTC, daniel fischer
none Details | Review

Description daniel fischer 2005-07-27 23:12:14 UTC
gst<->ffmpeg timestamp conversion has been moved to the new ffmpeg's
time_base.den/.num style, but in gst_ffmpeg_time_gst_to_ff, the AVRational 'bq',
describing gst's format (1/GST_SECOND), is not initialized. this messes up the
timestamps written by ffmuxers, at least i can observe that for the FLV format.
Comment 1 daniel fischer 2005-07-27 23:13:28 UTC
Created attachment 49858 [details] [review]
initialize bq to { 1, GST_SECOND }

seems the initialization has been left out by accident. this patch fixes muxer
timestamping for flv (and likely other formats).
Comment 2 Ronald Bultje 2005-07-28 07:29:28 UTC
Applied, thanks.