After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311129 - Intltool's copy of AM_PROG_MKDIR_P overrides Automake's one
Intltool's copy of AM_PROG_MKDIR_P overrides Automake's one
Status: RESOLVED FIXED
Product: intltool
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: intltool maintainers
intltool maintainers
Depends on:
Blocks: 311870 311874
 
 
Reported: 2005-07-21 11:15 UTC by Stepan Kasal
Modified: 2005-07-29 09:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the fix (770 bytes, patch)
2005-07-21 11:17 UTC, Stepan Kasal 		none Details | Review
remove mkdir_p (2.20 KB, patch)
2005-07-28 15:42 UTC, Stepan Kasal 		none Details | Review
Fixed patch (2.67 KB, patch)
2005-07-29 03:17 UTC, Rodney Dawes 		none Details | Review

Description Stepan Kasal 2005-07-21 11:15:52 UTC 
Macro IT_PROG_INTLTOOL (defined in intltool.m4) contains a copy of
AM_PROG_MKDIR_P from Automake 1.8.

This copy is always expanded.  This can be confusing when intltool is used for
example with Automake 1.9.x, which contains a slightly different code.
I think it's safer to expand the copy only if it is not defined.

On the other hand, this code was disabled for Autoconf 2.13 because of a
misplaced parenthesis.

The following patch fixes both issues.
Comment 1 Stepan Kasal 2005-07-21 11:17:08 UTC 
Created attachment 49506 [details] [review]
the fix
Comment 2 Rodney Dawes 2005-07-21 15:12:18 UTC 
I would rather just remove it and require newer versions of automake. 1.4 is so
terribly old now.
Comment 3 Stepan Kasal 2005-07-28 15:39:00 UTC 
Well, I found out the comment in the code is not exact: mkdir_p was introduced
in Automake 1.8.

Anyway, I noticed that Makefile.in.in doesn't use mkdir_p. (It was used in
$(mkinstalldirs) in previous versions.)

This means that we can indeed remove that code.
Comment 4 Stepan Kasal 2005-07-28 15:42:15 UTC 
Created attachment 49884 [details] [review]
remove mkdir_p

Remove the copy of AM_PROG_MKDIR_P, since intltool no longer uses mkdir_p.
Comment 5 Rodney Dawes 2005-07-29 03:17:36 UTC 
Created attachment 49908 [details] [review]
Fixed patch

This is the patch I just committed to CVS. Your patch removed an extra closing
]) from intltool.m4 which this fixes.
Comment 6 Rodney Dawes 2005-07-29 03:18:06 UTC 
Committed to CVS. Will look at your other patches in the morning.
Comment 7 Stepan Kasal 2005-07-29 09:05:51 UTC 
Thank you for catching that silly mistake.
Stepan