After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311013 - themed face browser issues
themed face browser issues
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.8.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 302166 310908 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-07-20 14:40 UTC by William Jon McCann
Modified: 2005-07-24 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (6.36 KB, patch)
2005-07-20 18:53 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2005-07-20 14:40:54 UTC 
The face browser window expands its height when more users are added.  The face
browswer background colors could also use some toning down.  

This is a side effect of the following change:

2005-04-15  Brian Cameron  <brian.cameron@sun.com>
        * gui/greeter/greeter_item_ulist.c,
          gui/greeter/greeter_parser.c,
          gui/greeter/themes/happygnome-list/happygnome.xml:
          Now allow theming of background colors in the Face
          Browser.  Also shrink the FaceBrowser so it is the
          same size as the treeview, so a big white space is
          not displayed under the FaceBrowser.  I probably
          did not pick good default colors in the xml file,
          but perhaps someone with a better design eye can
          give me a recommendation for better colors.
          Fixes bug #140312.
Comment 1 William Jon McCann 2005-07-20 18:53:40 UTC 
Created attachment 49480 [details] [review]
patch

This should fix it.  Also removes the rules hints as per the HIG.  Looks pretty
nice to me :)

Ok to commit?
Comment 2 Brian Cameron 2005-07-20 19:02:37 UTC 
Yes, looks good.  Please commit.  I think you've also fixed bug #310908.  Could
you close that as a duplicate if you agree?
Comment 3 William Jon McCann 2005-07-20 19:08:44 UTC 
*** Bug 310908 has been marked as a duplicate of this bug. ***
Comment 4 William Jon McCann 2005-07-20 19:11:08 UTC 
Committed, thanks.
Comment 5 William Jon McCann 2005-07-24 14:34:22 UTC 
*** Bug 302166 has been marked as a duplicate of this bug. ***