After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310544 - ability to make 'make check' advisory in tinderbox
ability to make 'make check' advisory in tinderbox
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: James Henstridge
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2005-07-15 21:15 UTC by Luis Villa
Modified: 2008-01-19 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
makes check not really fail, but still displays output as red/etc. (1.69 KB, patch)
2005-07-15 21:17 UTC, Luis Villa
rejected Details | Review
Add a unittestfails parameter to jhbuildrc (5.10 KB, patch)
2006-07-12 09:36 UTC, Jose Dapena Paz
none Details | Review

Description Luis Villa 2005-07-15 21:15:41 UTC
So... since so many things fail make check, I want to enable it, but at the same
time, since failing make check does not prevent the building of dependent
modules, I don't want it to block the build of later dependencies. Attached
patch does that, but hardcodes it, so probably not acceptable upstream.
Comment 1 Luis Villa 2005-07-15 21:17:16 UTC
Created attachment 49268 [details] [review]
makes check not really fail, but still displays output as red/etc.
Comment 2 James Henstridge 2005-08-22 10:10:24 UTC
This patch is a real hack.  I'll definitely consider making this sort of thing
less hacky when looking at the module type refactor though.
Comment 3 Jose Dapena Paz 2006-07-12 09:36:32 UTC
Created attachment 68798 [details] [review]
Add a unittestfails parameter to jhbuildrc

This patch adds a separate handling for unit tests failure in jhbuild. Autotools fire a TestsFailedError exception when there are errors running the tests. Then, the exception is checked in Package class when running, to decide if it has to fail or simply give an error message and continue.

A new jhbuildrc property called unittestfails (defaulted to True to keep the current behavior) controls this.
Comment 4 Craig Keogh 2007-12-22 10:40:29 UTC
jhbuild has a no poison mode that causes failures not to block the build of later dependencies. Specify -N or --no-poison from the command-line or set the following in .jhbuildrc:

nopoison = True
Comment 5 Frederic Peters 2008-01-19 19:26:44 UTC
2008-01-19  Frederic Peters  <fpeters@0d.be>

        * doc/C/jhbuild.xml, jhbuild/config.py, jhbuild/defaults.jhbuildrc,
        jhbuild/modtypes/autotools.py, jhbuild/modtypes/waf.py, tests/mock.py,
        tests/tests.py: added a new makecheck_advisory option, to specify
        whether failures when running "make check" should be advisory only
        and not cause the module to fail; complete with documentation and unit
        tests.  (closes: #310544)