After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310409 - Move Totem-media-properties to sidebar
Move Totem-media-properties to sidebar
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
1.1.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 322503 327016 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-07-14 20:38 UTC by Sebastien Bacher
Modified: 2006-07-12 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
properties moved to sidebar (141.79 KB, image/png)
2005-07-17 17:30 UTC, Luca Cavalli
  Details
totem-props-sidebar.patch (5.58 KB, patch)
2006-02-10 23:28 UTC, Bastien Nocera
needs-work Details | Review

Description Sebastien Bacher 2005-07-14 20:38:03 UTC
This bug has been opened here: https://bugzilla.ubuntu.com/12688

"The new sidebar is pretty cool but what about moving the
media-properties-dialog to the sidebar showing  actual media info updating
automatically if Playlistitem is changed."
Comment 1 Luca Cavalli 2005-07-17 17:30:10 UTC
Created attachment 49326 [details]
properties moved to sidebar

I have tried to move properties widget to sidebar. The effect is nice, but I
have to solve a:
Gtk-CRITICAL **: gtk_widget_set_sensitive: assertion `GTK_IS_WIDGET (widget)'
failed
before attaching the patch.
Moreover a more compact layout should be used.
Comment 2 Michaël Arnauts 2005-08-01 16:24:28 UTC
Looks cool! Now that there is a sidebar, it would be cool to get rid of that
dialog :)
Comment 3 Bastien Nocera 2006-01-15 11:49:04 UTC
*** Bug 327016 has been marked as a duplicate of this bug. ***
Comment 4 Bastien Nocera 2006-01-29 13:48:05 UTC
*** Bug 322503 has been marked as a duplicate of this bug. ***
Comment 5 Bastien Nocera 2006-02-10 23:28:56 UTC
Created attachment 59113 [details] [review]
totem-props-sidebar.patch

First pass at patch.
Need to see whether we can make it slightly smaller, and fix up the logo mode props.
Comment 6 Christoph Burghardt 2006-03-13 20:00:16 UTC
What problems needs to be fixed before applying this patch? Works for me(TM) and i like it..
Comment 7 Bastien Nocera 2006-07-12 09:25:37 UTC
(In reply to comment #6)
> What problems needs to be fixed before applying this patch? Works for me(TM)
> and i like it..
 
"Need to see whether we can make it slightly smaller, and fix up the logo mode
props." from comment 5...
Comment 8 Bastien Nocera 2006-07-12 09:50:12 UTC
2006-07-12  Bastien Nocera  <hadess@hadess.net>

        * data/properties.glade:
        * data/totem.glade:
        * src/backend/bacon-video-widget-xine.c:
        (bacon_video_widget_get_metadata_bool):
        * src/bacon-video-widget-properties.c:
        (bacon_video_widget_properties_new):
        * src/totem-sidebar.c: (totem_sidebar_setup):
        * src/totem.c: (totem_action_set_mrl_with_warning),
        (totem_callback_connect), (main):
        Move the properties dialogue to the sidebar (Closes: #310409)