After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310348 - "folder, x items" off-center in the side pane
"folder, x items" off-center in the side pane
Status: RESOLVED DUPLICATE of bug 43858
Product: nautilus
Classification: Core
Component: [obsolete] Sidebar
2.11.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-14 12:37 UTC by Vincent Noel
Modified: 2005-07-14 16:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
screenshot showing the problem (11.68 KB, image/png)
2005-07-14 12:38 UTC, Vincent Noel
Details
screenshot with ellipsis (12.57 KB, image/png)
2005-07-14 16:35 UTC, Vincent Noel
Details

Description Vincent Noel 2005-07-14 12:37:32 UTC
See upcoming screenshot
Comment 1 Vincent Noel 2005-07-14 12:38:14 UTC
Created attachment 49163 [details]
screenshot showing the problem
Comment 2 Christian Neumair 2005-07-14 12:57:41 UTC
The problem here is that pangolayouts on GtkLabel don't offer proper wrapping
and/or shrinking capabilities. I don't remember the details. 
Comment 3 Christian Neumair 2005-07-14 13:00:12 UTC
This is actually the same issue as described by bug 43858, although it refers to
another PangoLayout'ed label on the sidepane.

*** This bug has been marked as a duplicate of 43858 ***
Comment 4 Vincent Noel 2005-07-14 15:34:41 UTC
Mmmh, I'm not sure if it's a duplicate...
I'm not complaining about the string being cut on the left and right when the
pane is too small (as in bug 43858) - I'm saying that the "folder, x items"
string is not centered like the other items : if you resize the side pane, all
items are centered on the middle of the side pane, except this one.
Comment 5 Christian Neumair 2005-07-14 15:35:36 UTC
even if there is enough space for it?
Comment 6 Vincent Noel 2005-07-14 15:44:48 UTC
Yep - look at the screenshot in attachment 49163 [details] : the line should say "folder,
4 items". There is enough room to display it, but instead of being centered in
the middle of the side pane the line is centered on some other point further right.

If I expand the side pane wide enough to show the "date" line entirely, the
"folder, 4 items" line is centered fine.
Comment 7 Vincent Noel 2005-07-14 15:47:21 UTC
Oh, ok, I get it - the "folder" line is part in the same paragraph with the
"date" line, so both lines are centered on the same spot, which is dictated by
the width of the "date" line. Wouldn't it be possible to make them independent
lines ? Or is that a bad idea ?
Comment 8 Christian Neumair 2005-07-14 16:21:37 UTC
Yes we could...but I'm not really eager to make such half-assed fixes. The real
fix is to get GtkLabel wrapping done properly. Also, the impact is IMHO really
minor, since you can also read the number of containing items in the statusbar.
I think we could do way more useful things with the sidebar... .
Comment 9 Vincent Noel 2005-07-14 16:32:27 UTC
You're right :-) In the meantime, though, allowing ellipsis on the paragraph
actually helps a lot - the "folder" line becomes correctly centered and the side
pane looks a lot better overall...

Index: src/nautilus-sidebar-title.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-sidebar-title.c,v
retrieving revision 1.151
diff -u -r1.151 nautilus-sidebar-title.c
--- src/nautilus-sidebar-title.c        13 Jul 2005 12:23:37 -0000      1.151
+++ src/nautilus-sidebar-title.c        14 Jul 2005 16:27:09 -0000
@@ -469,6 +469,7 @@
        }
        gtk_label_set_text (GTK_LABEL (sidebar_title->details->more_info_label),
                            info_string->str);
+       gtk_label_set_ellipsize (GTK_LABEL
(sidebar_title->details->more_info_label), PANGO_ELLIPSIZE_END);

        g_string_free (info_string, TRUE);
Comment 10 Vincent Noel 2005-07-14 16:35:45 UTC
Created attachment 49178 [details]
screenshot with ellipsis

compare with previous screenshot