After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310221 - GtkIconTheme doesn't notice new unthemed icons
GtkIconTheme doesn't notice new unthemed icons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.7.x
Other Linux
: High normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-07-13 13:24 UTC by Mark McLoughlin
Modified: 2005-07-13 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtk-notice-new-unthemed-icons.patch (3.13 KB, patch)
2005-07-13 13:24 UTC, Mark McLoughlin
none Details | Review

Description Mark McLoughlin 2005-07-13 13:24:15 UTC
In Fedora, we're seeing a problem where users install a new package which
contains an unthemed icon and although the menu item appears in the menu, the
icon doesn't appear in the menu item. See:

  https://www.redhat.com/archives/fedora-extras-list/2005-July/msg00610.html

We thought the problem was an icon-theme.cache file in an unthemed icons dir
(bug #310131), but it turns out GtkIconTheme never checks the mtime on unthemed
icons directories like it does on theme directories.

Attaching a patch
Comment 1 Mark McLoughlin 2005-07-13 13:24:47 UTC
Created attachment 49089 [details] [review]
gtk-notice-new-unthemed-icons.patch
Comment 2 Matthias Clasen 2005-07-13 14:12:06 UTC
2005-07-13  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkicontheme.c (load_themes): Don't keep the caches
	for unthemed directories in a separate list, instead append
	them at the end of the dir_mtimes list, so that we can check
	them for staleness like the other caches.  (#310221, Mark 
	McLoughlin)