GNOME Bugzilla – Bug 309902
Popup menu cleanups
Last modified: 2006-09-28 19:26:16 UTC
- Connect to the "popup_menu" menu signal from the treeview - Show "Remove" for menu items - Show "Copy Location" when only one item is selected
See for examples: http://bugzilla.gnome.org/show_bug.cgi?id=309695
Created attachment 73292 [details] [review] Patch to cleanup playlist popup menu Some cleanups for the playlist popup menu: * use the UIManager API for the popup menu * suppport popup menus for multiple selected items * add a 'Remove' menuitem * use the 'popup-menu' signal
Comment on attachment 73292 [details] [review] Patch to cleanup playlist popup menu Looks good, except: <snip> >+static const GtkActionEntry entries[] = { >+ { "remove", GTK_STOCK_REMOVE, "_Remove", NULL, "Remove file from playlist", G_CALLBACK (playlist_remove_action_activated) }, >+ { "copy-location", GTK_STOCK_COPY, "_Copy location", NULL, "Copy the location to the clipboard", G_CALLBACK (playlist_copy_location_action_activated) } Is this missing i18n? Feel free to commit once that's fixed.
+ gtk_menu_popup (GTK_MENU (menu), NULL, NULL, NULL, NULL, + button, time); + + return TRUE; It's missing gtk_menu_shell_select_first (GTK_MENU_SHELL (menu), FALSE)); (ONLY) for the keyboard case.
Commited with fixed i18n and gtk_menu_shell_select_first call. 2006-09-28 Jan Arne Petersen <jpetersen@jpetersen.org> * data/Makefile.am: * data/playlist-ui.xml: * data/playlist.glade: * src/totem-playlist.c: (playlist_copy_location_action_activated), (playlist_show_popup_menu), (treeview_button_pressed), (playlist_treeview_popup_menu), (playlist_remove_files), (playlist_remove_button_clicked), (playlist_remove_action_activated), (totem_playlist_key_press), (init_treeview), (totem_playlist_finalize), (totem_playlist_new): cleanup the playlist popup menu. Use GtkUIManager, add support for multiple selections, add 'Remove' item. (Closes: #309902)