Created attachment 48775 [details] [review]
proposed implementation

I also cleaned up signal emission in rb-player-gst.c, since it was starting to
look a bit silly.

With the patch applied, I get a lot of
GLib-GObject-CRITICAL **: g_value_get_uint: assertion `G_VALUE_HOLDS_UINT
(value)' failed
messages with the following backtrace when I try to play a iradio station

+ Trace 62058

Created attachment 49923 [details] [review]
less broken patch

After checking that it all worked, I changed the type of the buffering
percentage from int to uint (to match totem).  I missed one spot, and cleverly
failed to test it afterwards.

The fixes those issues, and it gives us a buffering progress bar. However it
still locks up the UI for a few seconds during the initial connect, before the
buffering starts - that is more Bug 128106 (iradio connection is not
asynchronous) though.

The patch looks fine if you want it committed.

Please commit this.  Thanks.

2005-07-30  James Livingston  <jrl@ids.org.au>

        * player/rb-player-gst.c: (rb_player_class_init),
        (rb_player_finalize), (emit_signal_idle), (eos_cb), (error_cb),
        (deep_notify_cb), (buffering_cb), (rb_player_construct):
        * player/rb-player.h:
        * rhythmdb/rhythmdb.c: (rhythmdb_is_busy):
        * rhythmdb/rhythmdb.h:
        * shell/rb-shell-player.c: (rb_shell_player_class_init),
        (rb_shell_player_init), (rb_shell_player_set_property),
        (rb_shell_player_get_property), (rb_shell_player_open_location),
        (info_available_cb), (buffering_cb):
        * shell/rb-shell.c: (rb_shell_construct):
        * shell/rb-statusbar.c: (rb_statusbar_init),
        (rb_statusbar_sync_status), (poll_status),
        (rb_statusbar_set_progress), (rb_statusbar_entry_view_changed_cb):
        * shell/rb-statusbar.h: Patch from Jonathan Matthew
        <jonathan@kaolin.hn.org> to give a buffering indication for iradio
        sources (Closes 309708)