After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309642 - Register treeview icons as stock icons
Register treeview icons as stock icons
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: interface
2.11.x
Other All
: Normal enhancement
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-06 21:23 UTC by Luca Cavalli
Modified: 2005-07-14 16:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Sample screen shot (38.39 KB, image/png)
2005-07-06 21:24 UTC, Luca Cavalli
  Details
sj-play.png icon, put in /data (407 bytes, image/png)
2005-07-06 21:24 UTC, Luca Cavalli
  Details
sj-record.png icon, put in /data (316 bytes, image/png)
2005-07-06 21:25 UTC, Luca Cavalli
  Details
Custom stock icons support (4.17 KB, patch)
2005-07-06 21:26 UTC, Luca Cavalli
none Details | Review
speaker with red dot (281 bytes, image/png)
2005-07-14 15:50 UTC, Luca Cavalli
  Details
speaker with red dot, alternative version (281 bytes, image/png)
2005-07-14 15:50 UTC, Luca Cavalli
  Details
microphone (276 bytes, image/png)
2005-07-14 15:51 UTC, Luca Cavalli
  Details

Description Luca Cavalli 2005-07-06 21:23:08 UTC
It is more an esthetic aspect, than anything else, but I don't like too much
GTK_STOCK_MEDIA_PLAY icon used to mark the track being played. Although perfect
for a button or a menu item, it is too big in a player list, and also other
media players prefer to use other icons (like a small speaker).
I tried to add custom stock icons support to sound-juicer. Code is derived from
the GIMP project (with minor changes) and icons are derived from
icons/gnome/48x48/mimetypes/gnome-mime-audio.png.
Comment 1 Luca Cavalli 2005-07-06 21:24:11 UTC
Created attachment 48748 [details]
Sample screen shot
Comment 2 Luca Cavalli 2005-07-06 21:24:58 UTC
Created attachment 48749 [details]
sj-play.png icon, put in /data
Comment 3 Luca Cavalli 2005-07-06 21:25:35 UTC
Created attachment 48750 [details]
sj-record.png icon, put in /data
Comment 4 Luca Cavalli 2005-07-06 21:26:11 UTC
Created attachment 48751 [details] [review]
Custom stock icons support
Comment 5 Ross Burton 2005-07-13 10:05:44 UTC
I think SJ should use the same icons as totem uses in the playlist.
Comment 6 Luca Cavalli 2005-07-13 10:33:42 UTC
Hum... I'm not a big fan of "the ugly speaker" and prefer the music note. I
think we have two options. Change Totem to use the music note (but this will not
fit well with videos) or change SJ to use the speaker. Should we go for the
second option and use the speaker too?
Comment 7 Ross Burton 2005-07-13 10:58:44 UTC
Yes.
Comment 8 Ross Burton 2005-07-13 11:53:32 UTC
I've committed this.  If you can create a new record icon which matches the
playing icon, that would be great!
Comment 9 Luca Cavalli 2005-07-13 14:07:19 UTC
Sure, I will do in the next few days. Have you got in mind a specific icon? A
speaker with a red recording dot? Something else?
Comment 10 Ross Burton 2005-07-13 14:45:16 UTC
A speaker with a red dot sounds reasonable.  It's simple enought that I can
probably try it tonight too.
Comment 11 Luca Cavalli 2005-07-14 15:49:33 UTC
Hi, sorry not having drawn the icon in time for SJ release. I made a speaker
with a red dot on the right, one with a red dot on the left and a small
microphone. Choose the one you think fits better with SJ gui.
Comment 12 Luca Cavalli 2005-07-14 15:50:18 UTC
Created attachment 49173 [details]
speaker with red dot
Comment 13 Luca Cavalli 2005-07-14 15:50:47 UTC
Created attachment 49174 [details]
speaker with red dot, alternative version
Comment 14 Luca Cavalli 2005-07-14 15:51:42 UTC
Created attachment 49175 [details]
microphone
Comment 15 Ross Burton 2005-07-14 16:02:34 UTC
No worries, I wanted to get the release out asap.  I've updated CVS with the
alternative icon, thanks!