GNOME Bugzilla – Bug 309268
"play" should play the selected song
Last modified: 2005-08-01 09:26:07 UTC
with sound-juicer 2.11.3: * select a song * click on play the first song starts playing, it should pick the selected one rather
I'll let you and Ronald battle this one out...
This should be 3-4 lines of code in play.c... I guess it's what you'd expect, so yes, I should write those 3-4 lines of code. :).
Select a track and click on play. Suppose the selected track plays, what should be the behaviour when we click on PAUSE, select another track and again click on play ? Should the newly selected track play or the PAUSED track resume play ? Should there be any STOP button to ensure that a song is stopped before moving to next track?
No stop button. :). As for behaviour, currently pause is a semi-hardware-pause and semi-hardware-stop button, since it removes the title, for example (this is visual feedback). When title is removed, I'd say select-new-and-play would play the new one, whereas if the title would remain, i'd expect select-new to do nothing and continue palying the old one.
Created attachment 48593 [details] [review] Patch against the CVS HEAD When a track is selected and Play is clicked, that track is played. But still the above issue is yet to be decided.
Created attachment 48600 [details] [review] Patch against the CVS HEAD Whenever a track is selected and play button is clicked, the selected track is played. Thanks Ronald
Created attachment 48629 [details] [review] Patch against the CVS HEAD
Created attachment 48630 [details] [review] Updated patch
Ross: While playing, when selection changes, should it play the new selection. ie Should a single click start playing a selected track. The current behaviour of this patch is: 1. Select a track, click on play. It plays the selected track. 2. While playing, when the selection changes, it does nothing. But when the row is activated, the activated row is played. A Single click wont do anything. 3. While not playing, when selection changes, it is updated and when Play button is clicked, the latest selection is played.
No, selecting a track whilst playing shouldn't switch to it. If I press Pause and then Play again, does this patch carry on from where it was, or start the current track again?
If i Pause and Play the current track, i'll resume play. Also, if i Pause and change selection and come back to the old Paused track, and click on Play, it will resume Play.
Created attachment 49165 [details] [review] Latest patch against CVS HEAD Slighter modifications.
Hi Madhan, I've reorganised some of the code that you're touching here, to make your patch (and similar behaviour) easier to implement. Only the .glade file changes and the last chunk should now be needed to implement this feature. Can you update the patch and test it, so we can apply?
Created attachment 49954 [details] [review] Patch against CVS HEAD The extra code sets the Stock Item (loud speaker) to the playing track and set the title.
Small point, call gtk_tree_view_selection_set_mode in main() instead of on every selection.
Created attachment 50051 [details] [review] Patch against CVS head, as per Ross's comment
Committed, thanks