After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309180 - gtk.MessageDialog exposes private attributes
gtk.MessageDialog exposes private attributes
Status: RESOLVED FIXED
Product: pygtk
Classification: Bindings
Component: gtk
2.5.x/2.6.x
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-28 11:47 UTC by Steve Chaplin
Modified: 2009-02-22 21:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10



Description Steve Chaplin 2005-06-28 11:47:23 UTC
Please describe the problem:
gtk.MessageDialog exposes the 'image' and 'label' widgets which are private
attributes which are not intended to be made public.
In the past it was useful to have access to them because it allowed you to 
change the image and label (message) displayed in the MessageDialog.
But with GTK+ 2.6 we now have
        MessageDialog.set_markup ()             
        MessageDialog.format_secondary_markup ()
which let you change the label/message, and
        MessageDialog.set_property ('message-type', msg_type) 
which lets you change the image.

So I don't think that access to the private attributes 'image' and 'label' is
needed anymore and they should be removed (or deprecated).


Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Gustavo Carneiro 2005-07-29 21:29:59 UTC
Access to these attributes should be deprecated, but they can't be removed due
to API compatibility issues.
Comment 2 Gian Mario Tagliaretti 2009-02-22 21:22:08 UTC
I've added deprecation warnings accessing those fields, since gtk+-2.14 we also have set_image, so I've added that one in the deprecation text.