GNOME Bugzilla – Bug 309051
[PATCH] enable "streamheader" properties
Last modified: 2005-07-11 12:34:41 UTC
patch to enable streamheader properties (a la flumotion, as used by multifdsink) for ffmux_*. it has only been tested with flv, but should in theory work for any codec. after writing the header, the first packet is flushed. gstffmpegprotocol takes the first packet as header: it sets the appropriate GST_BUFFER_IN_CAPS flag on the buffer, and streamheader on the pad's caps.
Created attachment 48351 [details] [review] the described patch to enable streamheader caps.
Same here, please provide a patch in diff -u format.
Created attachment 48425 [details] [review] enable setting of the streamheader property diff -u it is, then:
This does so for *all* muxers, even the ones not supporting this. Can you add a limit so it only does this for flv?
Created attachment 48883 [details] [review] enable streamheader property (for flv only) ok, i'm feeding a flag (GST_FFMPEG_URL_STREAMHEADER) from ffmux to ffprotocol, if the format name is "flv", and only set streamheaders if the flag is set. (in theory, the method used for determining what should be set as streamheader should work for any format that writes a header with av_write_header, but i cannot test any but flv, so only flv is enabled.)
flags ^= GST_FFMPEG_URL_STREAMHEADER; that is wrong, should be &= ~flag;. Other than that, the patch is fine, so I'll correct that and apply. Thanks.