After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309051 - [PATCH] enable "streamheader" properties
[PATCH] enable "streamheader" properties
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: High enhancement
: 0.8.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-06-26 12:56 UTC by daniel fischer
Modified: 2005-07-11 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

the described patch to enable streamheader caps. (1.33 KB, patch)
2005-06-26 12:57 UTC, daniel fischer
none Details | Review
enable setting of the streamheader property (2.01 KB, patch)
2005-06-27 20:45 UTC, daniel fischer
needs-work Details | Review
enable streamheader property (for flv only) (3.99 KB, patch)
2005-07-09 22:01 UTC, daniel fischer
none Details | Review

Description daniel fischer 2005-06-26 12:56:40 UTC
patch to enable streamheader properties (a la flumotion, as used by multifdsink)
for ffmux_*. it has only been tested with flv, but should in theory work for any

after writing the header, the first packet is flushed. gstffmpegprotocol takes
the first packet as header: it sets the appropriate GST_BUFFER_IN_CAPS flag on
the buffer, and streamheader on the pad's caps.
Comment 1 daniel fischer 2005-06-26 12:57:13 UTC
Created attachment 48351 [details] [review]
the described patch to enable streamheader caps.
Comment 2 Ronald Bultje 2005-06-26 19:50:52 UTC
Same here, please provide a patch in diff -u format.
Comment 3 daniel fischer 2005-06-27 20:45:41 UTC
Created attachment 48425 [details] [review]
enable setting of the streamheader property

diff -u it is, then:
Comment 4 Ronald Bultje 2005-07-01 17:24:21 UTC
This does so for *all* muxers, even the ones not supporting this. Can you add a
limit so it only does this for flv?
Comment 5 daniel fischer 2005-07-09 22:01:51 UTC
Created attachment 48883 [details] [review]
enable streamheader property (for flv only)

ok, i'm feeding a flag (GST_FFMPEG_URL_STREAMHEADER) from ffmux to ffprotocol,
if the format name is "flv", and only set streamheaders if the flag is set.

(in theory, the method used for determining what should be set as streamheader
should work for any format that writes a header with av_write_header, but i
cannot test any but flv, so only flv is enabled.)
Comment 6 Ronald Bultje 2005-07-11 12:34:41 UTC

that is wrong, should be &= ~flag;. Other than that, the patch is fine, so I'll
correct that and apply. Thanks.