After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308851 - Fix some more grammar errors
Fix some more grammar errors
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.4.x
Other All
: Normal normal
: ---
Assigned To: André Klapper
Evolution QA team
Depends on:
Blocks: 236276
 
 
Reported: 2005-06-23 23:15 UTC by Adam Weinberger
Modified: 2013-09-13 00:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
partial patch, does NOT change the word "modify" to "funkify". (1.95 KB, patch)
2005-06-25 14:59 UTC, André Klapper
reviewed Details | Review
second patch as per harish's last comment (1.95 KB, patch)
2005-07-20 09:31 UTC, André Klapper
accepted-commit_now Details | Review

Description Adam Weinberger 2005-06-23 23:15:26 UTC
#: calendar/gui/dialogs/recur-comp.c:52                                         
msgid "You are modifying a recurring event, what would you like to modify?"    

#: calendar/gui/dialogs/recur-comp.c:54
msgid "You are delegating a recurring event, what would like to delegate?"

#: calendar/gui/dialogs/recur-comp.c:58
msgid "You are modifying a recurring task, what would you like to modify?"

#: calendar/gui/dialogs/recur-comp.c:62                                         
msgid ""                                                                        
"You are modifying a recurring journal entry, what would you like to modify?"


You cannot simply combine two sentences by dropping in a comma. Each of these should be changed 
to the form:
"You are funkifying a recurring journal entry. What would you like to funkify?"
Comment 1 André Klapper 2005-06-24 15:08:29 UTC
hmm. right. it's at least paradox to get told what i am modifying and then 
asking me what i would like to modify in one sentence... :-)

adding dependency, i'm going to provide a fix for this.
Comment 2 André Klapper 2005-06-25 14:52:38 UTC
the word "funkify" has a different meaning to me. i also cannot find it in the 
dictionary (but in the web, of course). i doubt it's useful to change "modify" 
to "funkify", since everybody uses "modify" and the entire application uses 
"modify".
well, i've written a patch to change the "," into "."

i'm going to send it to e-p mailing list and attach it here.
Comment 3 André Klapper 2005-06-25 14:59:21 UTC
Created attachment 48320 [details] [review]
partial patch, does NOT change the word "modify" to "funkify".

also sent to e-p
Comment 4 Adam Weinberger 2005-06-25 15:42:32 UTC
Heh. The "funkify" was an example to show punctuation change, not word change :P
Comment 5 Adam Weinberger 2005-06-25 15:44:09 UTC
Patch looks good, BTW.
Comment 6 Harish Krishnaswamy 2005-07-20 05:12:46 UTC
msgid "You are delegating a recurring event, what would like to delegate?"
 - misses a 'you' here. Other than that, the patch is fine.
Comment 7 André Klapper 2005-07-20 09:31:53 UTC
Created attachment 49445 [details] [review]
second patch as per harish's last comment

second patch, regarding harish's last comment. i really haven't seen that,
thanks for pointing it out. :-)
Comment 8 André Klapper 2005-07-20 09:34:46 UTC
(getting it in would currently require announcement. but i'm really voting for
getting most of our *many* patches into 2.3... sigh...)
Comment 9 Adam Weinberger 2005-07-20 09:55:42 UTC
patch looks good to me.
Comment 10 Adam Weinberger 2005-08-09 02:22:48 UTC
Any further thoughts on this?
Comment 11 André Klapper 2005-08-30 09:31:31 UTC
still valid in 2.3.8/2.4.0, targetting to 2.5.
Comment 12 André Klapper 2005-12-20 09:49:53 UTC
just committed it to CVS HEAD: http://cvs.gnome.org/viewcvs/evolution/calendar/gui/dialogs/recur-comp.c?r1=1.16&r2=1.17

this patch will be included in evolution 2.5.4.