GNOME Bugzilla – Bug 308634
EOG doesn't update the folder of filesystem changes happen
Last modified: 2005-07-15 15:32:17 UTC
Check out the diff that I'll attach after this bug report is submitted Other information:
Created attachment 48149 [details] [review] Implementation for this featurerequest
Is everybody okay with me committing this? I might checkout some other eog bugs sooner or later, but I'm not promising that I'll start maintaining it :-). I'll see .. maybe, maybe not (it's code isn't very clean, you know).
You'll see a cleanup_dead_files() function. The reason why I didn't use the GNOME_VFS_MONITOR_EVENT_DELETED is that this only works correctly on file monitors. I prefer using a directory monitor. Else I'll have to manage a monitor (and clean it up) for every file being previewed which is probably way more overhead than on deletion/rename/create loop all the previewed items and check if they still exist. And also is the code so damned ugly and clumbsy that it's very hard to keep a pointer to the monitor-handle per previewed file. I have a copy of the .c file where I am doing that, but it makes the code look damn ugly and the diff large. Btw. I don't know who to ask to get approval for commit since there's currently no maintainer, of course
Philip: Wait for the new maintainer.
Waiting ... Please notify me when the patch goes in, or when I may commit this one.
Philip: Thanks for the patch. I finally got my gamin stuff working so I could test this one. Looks great except that when a new file is added to a directory, a thumbnail is not generated...is that the expected behavior? I will take a look and see if I can figure it out.
Patch has been applied to beat the feature freeze deadline.
@Tim: That isn't expected behavior. Must be something with the signal-handlers for the model. Since the creation of the icon happens when the model changes. The creating of a new file should trigger it.
*** This bug has been marked as a duplicate of 310463 ***
Bug 310509 is related.