After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308634 - EOG doesn't update the folder of filesystem changes happen
EOG doesn't update the folder of filesystem changes happen
Status: RESOLVED DUPLICATE of bug 310463
Product: eog
Classification: Core
Component: image viewer
git master
Other All
: Normal minor
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-22 10:39 UTC by Philip Van Hoof
Modified: 2005-07-15 15:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Implementation for this featurerequest (7.85 KB, patch)
2005-06-22 10:40 UTC, Philip Van Hoof
none Details | Review

Description Philip Van Hoof 2005-06-22 10:39:18 UTC
Check out the diff that I'll attach after this bug report is submitted


Other information:
Comment 1 Philip Van Hoof 2005-06-22 10:40:09 UTC
Created attachment 48149 [details] [review]
Implementation for this featurerequest
Comment 2 Philip Van Hoof 2005-06-22 10:41:30 UTC
Is everybody okay with me committing this? I might checkout some other eog bugs
sooner or later, but I'm not promising that I'll start maintaining it :-).

I'll see .. maybe, maybe not (it's code isn't very clean, you know).
Comment 3 Philip Van Hoof 2005-06-22 10:47:39 UTC
You'll see a cleanup_dead_files() function. The reason why I didn't use the
GNOME_VFS_MONITOR_EVENT_DELETED is that this only works correctly on file monitors.

I prefer using a directory monitor. Else I'll have to manage a monitor (and
clean it up) for every file being previewed which is probably way more overhead
than on deletion/rename/create loop all the previewed items and check if they
still exist.

And also is the code so damned ugly and clumbsy that it's very hard to keep a
pointer to the monitor-handle per previewed file. I have a copy of the .c file
where I am doing that, but it makes the code look damn ugly and the diff large.

Btw. I don't know who to ask to get approval for commit since there's currently
no maintainer, of course
Comment 4 Olav Vitters 2005-06-24 17:46:24 UTC
Philip: Wait for the new maintainer.
Comment 5 Philip Van Hoof 2005-07-06 13:14:06 UTC
Waiting ... 

Please notify me when the patch goes in, or when I may commit this one.
Comment 6 Tim Gerla 2005-07-09 18:26:36 UTC
Philip: Thanks for the patch. I finally got my gamin stuff working so I could
test this one. Looks great except that when a new file is added to a directory,
a thumbnail is not generated...is that the expected behavior? I will take a look
and see if I can figure it out.
Comment 7 Tim Gerla 2005-07-10 19:48:59 UTC
Patch has been applied to beat the feature freeze deadline.
Comment 8 Philip Van Hoof 2005-07-10 23:40:49 UTC
@Tim: That isn't expected behavior. Must be something with the signal-handlers
for the model. Since the creation of the icon happens when the model changes.
The creating of a new file should trigger it.
Comment 9 Philip Van Hoof 2005-07-15 09:31:28 UTC

*** This bug has been marked as a duplicate of 310463 ***
Comment 10 Philip Van Hoof 2005-07-15 15:32:17 UTC
Bug 310509 is related.