After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308614 - New Mail dialog's menu bar doesn't follow HIG
New Mail dialog's menu bar doesn't follow HIG
Status: VERIFIED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.4.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks: 310550
 
 
Reported: 2005-06-22 08:36 UTC by Sven Herzberg
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to change menu order due to HIG (1.81 KB, patch)
2005-09-24 10:56 UTC, André Klapper
accepted-commit_now Details | Review

Description Sven Herzberg 2005-06-22 08:36:51 UTC
Open the new mail dialog:
the menu bar looks like this:
file - edit - format - view - insert - security

The HIG recommends this order:
file - edit - view - insert - format - <app specific stuff after format>
see: http://developer.gnome.org/projects/gup/hig/2.0/menus-standard.html
Comment 1 André Klapper 2005-06-22 14:55:06 UTC
adding HIG keyword

dobey: adding you to CC since you're wokring on the menu rewrite
Comment 2 Not Zed 2005-06-24 16:13:19 UTC
the menu's are in the gtkhtmleditor
Comment 3 André Klapper 2005-08-29 12:20:20 UTC
still valid in 2.3.8, retargetting to 2.5; adding dependency
Comment 4 André Klapper 2005-09-24 10:54:17 UTC
this menu is NOT in gtkhtml but in "evolution/ui/evolution-message-composer.xml"

attaching a patch; can also be applied to 2.4.x since it does not break strings,
just their order (tested this locally).
Comment 5 André Klapper 2005-09-24 10:56:04 UTC
Created attachment 52590 [details] [review]
patch to change menu order due to HIG
Comment 6 André Klapper 2005-09-25 01:10:53 UTC
damn, of course only to 2.5 and NOT to 2.4 due to ui freeze (my bad, comment #4)
Comment 7 parthasarathi susarla 2005-09-26 11:06:58 UTC
This looks fine. Thanks for the patch andre :)
Comment 8 parthasarathi susarla 2005-09-26 11:16:48 UTC
Committed to head on behalf of andre, since he does not have commit rights
Comment 9 C Shilpa 2005-10-28 04:16:25 UTC
verified using evolution-2.5.1.0.200510261813-0.snap.novell.0.1