GNOME Bugzilla – Bug 308497
"import training text" should append the imported text to the user's training text file too
Last modified: 2021-05-26 09:58:24 UTC
I think most users will expect the "Dasher learns all the time" motto to imply that imported training text is remembered into the future, just like writing is remembered.
A better way of doing this might be to add a checkbox to the file open dialog saying "Always use this training text" (or something similar). Otherwise overuse of this would result in a huge personal training text, which would make startup much slower. Another option may be to extend the import training text functionality - rather than append to the user's existing file, have a list of files that are opened on training. The user can then add or remove files from this.
Created attachment 109667 [details] [review] Optional Learning of Training Text An initial less-than-optimal implementation, just pops up a dialog after the file is chosen letting the user pick to make it a permanent addition, or temporary.
Thanks for producing this patch. I'm afraid that I can't get the result of applying this to trunk to work properly - you end up with two definitions of gtk_dasher_control_train in GtkDasherControl.cpp. I'm not sure whether this is a result of trunk having changed since you wrote the patch. I think that it's fine just to call the existing version of gtk_dasher_control_train if the user choses not to permenantly add the imported training text to their file. It might be a good idea to put the code which deals with adding the imported text to the user's training file in one of the files in the DasherCore directory - that way we should (in theory) get the same functionality in Windows for free. Maybe gtk_dasher_control_train should take an additional parameter which determines whether the imported text is saved?
My bad, that was an outdated patch, I'll submit a new and clean one now. The problem with 'free' cross platform is that it requires new ui elements.(maybe this is free with gtkmm, not 100% sure) Either way, I need to re-evaluate how we add 'permanent' learning. What is the recommended method to call to save the text? I was calling CNodeCreationManager::LearnText() but is that really the method to call? Let me know!
Created attachment 110215 [details] [review] updated patch A fixed patch, should compile/run, not really sure if it works though.. need some code review from someone on the dasher team.
Hey all - just following up on this. GOPA is winding down and I want to make sure people who have accomplished the appropriate number of short term tasks are awarded appropriately. Is this patch something that can be checked in and does it close this bug?
I would say that Matthew's suggestion in comment 1 should apply to both: to the imported text and to the newly written text. For the imported text by adding an appropriate checkbox to the file dialog; for newly written text by adding a check box next to popup menu for the language choice to the statusbar. Remains the question: at what moment should the newly written text be permanently saved? The following bug deals with that question: http://bugzilla.gnome.org/show_bug.cgi?id=308497
Sorry, wrong link in the preceding message; here is the correct link: http://bugzilla.gnome.org/show_bug.cgi?id=308498
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/dasher/-/issues/ Thank you for your understanding and your help.