GNOME Bugzilla – Bug 308475
potentially incorrect activation_uri when drive is mounted from file chooser
Last modified: 2005-06-21 14:53:38 UTC
The gnome-vfs backend for the GTK file chooser (incorrectly) makes the
assumption that the activation_uri for the GnomeVFSVolume that is the result of
a mount within the file chooser will be the same as for the GnomeVFSDrive that
it stems from.
In fact, the activation_uri for the GnomeVFSDrive is, at best, a guess since it
is derived from e.g. /etc/fstab and the user may use a different mount program
(e.g. pmount) that mounts the file system in another location which may be
unknown (and private to e.g. pmount) at GnomeVFSDrive creation time. Ideally,
we'd remove activation_uri from GnomeVFSDrive (since it makes little sense qua
the above explanation) but I suppose we cannot break API/ABI in gnome-vfs :-/.
One simple solution is to check whether the GnomeVFSDrive has got a
corresponding GnomeVFSVolume and use the activation_uri from this. Will attach
patch that does exactly this. This patch works for me but I'm unsure this is the
best approach. I've copied alexl on this bug for comments as well.
Created attachment 48076 [details] [review]
Please review. Thanks.
looks good to me.
Marking as accepted-commit_now based on the last comment.
Patch is now committed to CVS. Thanks.